Conversation
amyavi
reviewed
Sep 24, 2026
| return checkSelectors(arr, 1); | ||
| } | ||
| case "/minecraft:dialog", "/dialog" -> { | ||
| if (command.contains("can_close_with_escape")) { |
Contributor
There was a problem hiding this comment.
This is trivial to bypass by simply using unicode character escapes.
Author
There was a problem hiding this comment.
either the unicode character escapes can be resolved or (probably, new dep or much code) better, probably just parse snbt
Author
There was a problem hiding this comment.
added it by accident, because i use git add . and this was not in gitignore. resolved in 08a130f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the p in can_close_with_escape in the dialog command with a q, making the dialog never unclosable.
This is acomplishable because dialog takes any snbt that is a dialog, including extra nbt.