Repository navigation
Name the CDJ-1500X wherever the READMEs say which players have played a drive - #108
Merged
Merged
Conversation
… a drive A CDJ-1500X on firmware 1.10 mounts a drive Booth writes from its own slot and plays it, with the phrases drawn under the waveform, as the 0.0.8 changelog, the spec's status and the website already say. The README's opening, the app README's OneLibrary section and the command-line README's account of the hardware named only the CDJ-3000X and the CDJ-3000. Two of those also said a CDJ-3000 had played from the OneLibrary database. It reads the legacy one written beside it, which the same paragraphs go on to say, so they now say that instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tjgDHGCsZrZcZPVL4Dmon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CDJ-1500X on firmware 1.10 has mounted a USB drive Booth wrote and played from it. The 0.0.8 changelog, the spec's status table, the website and the app README's "what it does not do yet" list already said so. Three places that name the players still listed only the CDJ-3000X and the CDJ-3000.
What changed
README.md, the opening paragraph: now names a CDJ-3000X, a CDJ-1500X and a CDJ-3000 on firmware 3.22.booth/README.md, "OneLibrary, and what it would take": a CDJ-3000X and a CDJ-1500X have played from the OneLibrary database, and a CDJ-3000 from the legacy one beside it.proto/musicai/README.md: the hardware paragraph under Export now names the 1500X. It describes what was actually seen on that player: it mounts the drive from its own slot, plays it, and draws the phrases under the waveform. The OneLibrary sentence under Notes now names it too.Why it's right
The old wording in two of those places said a CDJ-3000 had played "from" the OneLibrary database. It doesn't read that one; it reads
export.pdb, as the same paragraphs went on to say. Now they say so directly, which also gets rid of a repeated sentence.The other way would have been to write the 1500X into the README opening's list of everything that came up on the decks, Pro DJ Link included, without separating it out. Where the changelog and the app README say exactly what was seen on the 1500X, I've kept to that.
Worth a second opinion
compat::Player. It reads OneLibrary like the 3000X, but its formats and sample-rate ceiling haven't been checked here.Gates pass:
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, andenv -u BOOTH_WHISPER_MODEL -u BOOTH_WHISPER_BIN -u BOOTH_GENRE_MODEL cargo test --workspace(31 test binaries).Generated by Claude Code