Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

ssc init should default to port 1433 #145

Description

@Jaxelr

Describe the Feature

When running ssc init currently the default value for port is undefined, this causes the field to be NaN on display and Null on creation.

image

As i understand it, it would be a more pleasant UX to default to port 1433, which is the usual sql server default port.

image

Todo

Suggested Solution

The suggested solution is to on line 62 of the init.ts command file switch to 1433 the default value:

default: conn.port || undefined,
message: 'Server port.',
name: 'port',
type: 'number',
when: (answers) => answers.path !== PathChoices.WebConfig,

Other Information

I can make the PR, but i wanted to discuss it first, in case there's some scenarios i am not considering.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions