fix: avoid panic on invalid signature input#29
Open
nacardin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two denial-of-service bugs in the signature verification path.
The library parses the Signature and Signature-Input headers of incoming
requests before any cryptographic check runs, so the bytes it sees are fully
attacker-controlled. Two of those parse steps could panic on malformed input:
A negative "created" or "expires" timestamp. These are valid Structured
Field integers but were converted to u64 with .unwrap(), so a value like
created=-1 panicked.
An undefined @-prefixed derived component name. The
name lookup called panic! on anything it didn't recognize.
Either one lets an unauthenticated client crash the verifier just by sending a
crafted header.
The fix makes both paths return a normal parse error instead of panicking.