Quality: Locale-sensitive lowercasing can break module detection#4000
Draft
tuanaiseo wants to merge 1 commit intojsx-eslint:masterfrom
Draft
Conversation
The rule checks `require()`/`import` source names using `pragma.toLocaleLowerCase()`. Locale-sensitive casing can produce incorrect results in some locales (for example Turkish casing), causing false negatives/positives when resolving React pragma imports. Affected files: isDestructuredFromPragmaImport.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4000 +/- ##
==========================================
+ Coverage 97.58% 97.74% +0.15%
==========================================
Files 137 137
Lines 10182 10182
Branches 3795 3795
==========================================
+ Hits 9936 9952 +16
+ Misses 246 230 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ljharb
requested changes
Apr 8, 2026
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I think this might be intentional - but either way, we’d need regression tests
Member
|
Also, please be sure any LLM usage is for your own edification and not to generate comments and code :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The rule checks
require()/importsource names usingpragma.toLocaleLowerCase(). Locale-sensitive casing can produce incorrect results in some locales (for example Turkish casing), causing false negatives/positives when resolving React pragma imports.Severity:
mediumFile:
lib/util/isDestructuredFromPragmaImport.jsSolution
Replace
toLocaleLowerCase()withtoLowerCase()for stable, locale-independent module name normalization.Changes
lib/util/isDestructuredFromPragmaImport.js(modified)Testing