Fix ESLint v10 RuleContext API removal (follow-up to #3972) by ledsun · Pull Request #3979 · jsx-eslint/eslint-plugin-react

ledsun · 2026-02-09T02:35:00Z

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

ljharb

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

codecov · 2026-02-11T08:15:43Z

Codecov Report

❌ Patch coverage is 49.49495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.26%. Comparing base (9af8845) to head (ea44283).

Files with missing lines	Patch %	Lines
lib/util/eslint.js	21.87%	50 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   94.76%   97.26%   +2.50%     
==========================================
  Files         134      137       +3     
  Lines       10165    10252      +87     
  Branches     3794     3833      +39     
==========================================
+ Hits         9633     9972     +339     
+ Misses        532      280     -252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

karlnorling · 2026-03-02T14:06:49Z

@ledsun do you have time to address the failing checks. I'm looking at updating to eslint 10 and we're using the eslint-plugin-react

ledsun · 2026-03-17T10:05:28Z

@ljharb all checks are passing now.
Please take another look when you have a moment.

Upon reviewing the code, I found additional areas that needed fixes in the helper for test code and in tests/lib/rules/jsx-no-undef.js. I have split each fix into separate commits and included comments.

- pnpm override: ledsun/eslint-plugin-react#2648f5b (jsx-eslint/eslint-plugin-react#3979) - Renovate: disable automerge for eslint major updates (devDeps rule was too broad) Made-with: Cursor

* chore(deps): update dependency eslint to v10 * fix(deps): pin eslint-plugin-react for ESLint 10 until upstream release - pnpm override: ledsun/eslint-plugin-react#2648f5b (jsx-eslint/eslint-plugin-react#3979) - Renovate: disable automerge for eslint major updates (devDeps rule was too broad) Made-with: Cursor --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vincent Schoener <1213200+vschoener@users.noreply.github.com>

Guymestef · 2026-03-25T08:26:16Z

@ljharb hello, any news on this PR?

socket-security · 2026-03-29T07:35:21Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint@10.1.0

View full report

ljharb · 2026-04-01T20:53:38Z

I've pushed some of the commits from this PR to master, but it looks like we're blocked on import-js/eslint-plugin-import#3227.

## Why 依存アップグレード（Next.js 16 / React 19 / ESLint 9 フラットコンフィグ等）で `yarn build` / `yarn lint` / CI インストールが壊れていたので、ビルドチェーンを再び通るようにする。併せて調査中に判明した Tailwind / shadcn スタック一式や、役目を終えた依存の残骸も掃除する。 ## What ### Next.js 16 / ESLint 9 アップグレード対応 - `next lint` 廃止に伴う ESLint フラットコンフィグ移行（`eslint.config.mjs`） - Next.js 16 の purity lint / set-state-in-effect ルールに合わせた `GameTyping.tsx` / `RankingTabs.tsx` / `game/page.tsx` の修正 - `tsconfig.json` を Next.js の自動補正（`jsx: react-jsx` / `.next/dev/types/**` の include 追加）に追従 ### Tailwind / shadcn スタック撤去実態として `@tailwind` ディレクティブも Tailwind ユーティリティクラスも使われていないため、関連パッケージ・設定ファイルを一式削除: - **dependencies** 削除: `clsx`, `tailwind-merge`, `tailwindcss-animate`, `@radix-ui/react-slot`, `@radix-ui/react-toast`, `class-variance-authority`, `lucide-react` - **devDependencies** 削除: `tailwindcss`, `@tailwindcss/postcss`, `postcss`, `autoprefixer` - **ファイル削除**: `tailwind.config.ts`, `postcss.config.js`, `src/libs/shadcn/` - autoprefixing は Next.js 組み込みの PostCSS パイプライン（`postcss-preset-env`）に委譲 ### 依存整備 - `@testing-library/react` の peer 要件である `@testing-library/dom` を明示追加 - `prettier` を `dependencies` → `devDependencies` に分類修正 - `@types/node` / `eslint` / `prettier` / `tsx` の patch / minor 追従 - `@next/codemod` が自動挿入した `@types/react` / `@types/react-dom` の `resolutions` ブロックを削除（React 19 エコシステム成熟により不要、むしろ古い `19.0.1` / `19.0.2` に固定される副作用が出ていた） - `openapi-typescript` v6 → v7 bump に合わせて `v1.d.ts` を v7 format で再生成 - `RankingTabs.tsx` の未使用 `useCallback` import 削除 - Yarn 4（Corepack）で `yarn.lock` をクリーン再生成 ## How - `tsconfig.json` の差分（`jsx` 変更・include 追加）は Next.js 16 が `next build` 時に自動で書き戻すもので、手動の設計変更ではない。ログ上も `jsx was set to react-jsx (next.js uses the React automatic runtime)` として明示される。 - `postcss.config.js` を削除することで Next.js 組み込みの PostCSS デフォルトにフォールバックする構成。最終出力 CSS（ベンダープレフィックス等）は従前と同じ。 - ESLint は `^9.39.4` 固定（v10 非対応）: `eslint-plugin-react` が ESLint v10 で削除されたレガシー API（`context.getFilename()`）に依存しているため、上流修正 ([jsx-eslint/eslint-plugin-react#3979](jsx-eslint/eslint-plugin-react#3979)) が公開されるまで v9 に留める。参考: [vercel/next.js#89764](vercel/next.js#89764) - lint は 0 errors（既存の `<img>` 6 件と 1 件の `react-hooks/exhaustive-deps` 警告のみ残る。いずれも今回のスコープ外） ## Validation - `corepack yarn install --immutable` - `corepack yarn format:ci` - `corepack yarn lint` - `corepack yarn build` - `corepack yarn test --runInBand` ## References - [Next.js 16 upgrade guide](https://nextjs.org/docs/app/guides/upgrading/version-16) - [Next.js ESLint migration / flat config](https://nextjs.org/docs/app/api-reference/config/eslint) - [Next.js codemods](https://nextjs.org/docs/app/guides/upgrading/codemods) - [Tailwind CSS v4 upgrade guide](https://tailwindcss.com/docs/upgrade-guide) - [vercel/next.js#89764 — ESLint v10 incompatibility](vercel/next.js#89764) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ijstokes

Skimmed code, detailed review of PR text, tested in UI. Works well. Accepting.

…-react/eslint-plugin (#27011) ## Summary - Replace `eslint-plugin-react` (~7.37.5) with `@eslint-react/eslint-plugin` (~2.13.0) in `@fluidframework/eslint-config-fluid` to unblock ESLint 10 adoption - Use the `recommended-typescript` preset which auto-disables rules already handled by TypeScript - Keep `eslint-plugin-react-hooks` separately — it already has ESLint 10 support and provides React Compiler rules - Switch `print-configs` script from `tsx` to `jiti` to fix ESM-only package resolution ### Why `eslint-plugin-react` 7.37.5 is broken with ESLint 10 — it calls `context.getFilename()` which was removed. The upstream fix ([jsx-eslint/eslint-plugin-react#3979](jsx-eslint/eslint-plugin-react#3979)) has been blocked since February 2026. `@eslint-react` v2.13.0 supports ESLint 8/9/10, so this works now and won't block the ESLint 10 upgrade. ### Consumer updates Per-package eslint config and package.json updates (rule renames, removing redundant devDeps) will come in a follow-up PR stacked on this one. Resolves #27009

ljharb reviewed Feb 10, 2026

View reviewed changes

ljharb marked this pull request as draft February 10, 2026 02:09

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

72b1aaf

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 sergeyklay/oar#269

Merged

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

30bc6ee

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

Track reverting to upstream eslint after temporary fork sergeyklay/oar#270

Closed

Copilot AI mentioned this pull request Feb 10, 2026

docs: create ESLint 10 compatibility tracking document sergeyklay/oar#271

Closed

sergeyklay mentioned this pull request Feb 10, 2026

Tracking: ESLint 10 Support sergeyklay/oar#272

Closed

6 tasks

ledsun force-pushed the update-deprecated-calls-v8 branch from f987ffa to a7b967b Compare February 11, 2026 08:06

ledsun marked this pull request as ready for review February 11, 2026 12:08

domarmstrong reviewed Feb 12, 2026

View reviewed changes

Comment thread lib/util/eslint.js Outdated

Comment thread lib/util/version.js Outdated

ljharb reviewed Feb 12, 2026

View reviewed changes

Comment thread lib/util/makeNoMethodSetStateRule.js

ljharb requested changes Feb 13, 2026

View reviewed changes

Comment thread .github/workflows/node-18+.yml Outdated

Comment thread lib/util/version.js Outdated

Comment thread package.json Outdated

This was referenced Feb 14, 2026

Downgrade ESLint to v9.39.2 due to plugin incompatibility cybersemics/em#3804

Closed

Add ESLint v10 required dependencies and restore .eslintignore qlik-oss/nebula.js#1906

Closed

lpicchi mentioned this pull request Feb 17, 2026

ESLint v10 compatibility #3977

Open

2 tasks

This was referenced Feb 18, 2026

Add pnpm patch for eslint-plugin-react ESLint 10 compatibility tdkn/blog#1987

Closed

docs: ESLint 10 upgrade investigation and compatibility analysis Amsterdam/design-system#2426

Closed

testower mentioned this pull request Feb 19, 2026

ESLint 10 upgrade deferred opentripplanner/OpenTripPlanner#7319

Open

tresdonicf mentioned this pull request Feb 19, 2026

Task: Upgrade to eslint 10 Enterprise-CMCS/demos#846

Closed

ljharb reviewed Feb 19, 2026

View reviewed changes

Comment thread .github/workflows/eslint-9+.yml Outdated

Comment thread .github/workflows/eslint-8-.yml

Comment thread .github/workflows/eslint-9+.yml Outdated

ledsun force-pushed the update-deprecated-calls-v8 branch from 6a95ab9 to 13c7805 Compare February 21, 2026 08:05

StyleShit mentioned this pull request Feb 22, 2026

chore: update eslint to 10.x [AR-48952] drivenets/design-system#186

Merged

Snoww3d mentioned this pull request Feb 22, 2026

chore: migrate eslint 9 → 10 Snoww3d/jwst-data-analysis#347

Closed

casaub0n mentioned this pull request Feb 24, 2026

ESLint v10 casaub0n/casaub0n#6036

Closed

ARADDCC002 mentioned this pull request Feb 25, 2026

Update frontend to use ESLint v10 gchq/Bailo#3286

Open

ActiveChooN mentioned this pull request Feb 25, 2026

📋 [TASK] Migrate ESLint to v10 open-edge-platform/anomalib#3373

Open

casaub0n mentioned this pull request Mar 1, 2026

update eslint version casaub0n/casaub0n#6192

Merged

guillaumejparis mentioned this pull request Mar 18, 2026

[frontend] chore(deps): update eslint monorepo to v10 (major) OpenAEV-Platform/openaev#5168

Open

1 task

Lucky3028 mentioned this pull request Mar 20, 2026

chore(deps): update eslint monorepo to v10 (major) clov3r-cc/auto-run-ac#438

Closed

1 task

This was referenced Mar 22, 2026

chore(renovate): group eslint toolchain and refine Next patterns vschoener/front.vincelivemix#244

Merged

chore(renovate): disable digest PRs for eslint-plugin-react pnpm override vschoener/front.vincelivemix#245

Merged

mgcronin mentioned this pull request Mar 25, 2026

chore(deps): Dependency Upgrade Round 2 — Zod 4, TypeScript 6, lucide-react 1.x zyloslabs/talos#308

Merged

ljharb force-pushed the update-deprecated-calls-v8 branch from 2648f5b to d309eb0 Compare March 29, 2026 07:33

ljharb force-pushed the update-deprecated-calls-v8 branch 2 times, most recently from 0802ab4 to 635cd2c Compare April 1, 2026 03:19

ljharb force-pushed the master branch from 2df8be2 to 012ec39 Compare April 1, 2026 20:54

danielhjacobs mentioned this pull request Apr 2, 2026

Fix resolve install in old npm version on CI. import-js/eslint-plugin-import#3237

Merged

jonathanperis mentioned this pull request Apr 6, 2026

Bump eslint from 9.39.4 to 10.2.0 jonathanperis/jonathanperis.github.io#30

Closed

ondrej-svec mentioned this pull request Apr 10, 2026

Bump eslint from 9.39.4 to 10.2.0 in /dashboard ondrej-svec/harness-lab#5

Closed

KinjiKawaguchi mentioned this pull request Apr 10, 2026

build(frontend): Next.js 16アップグレード後のビルド修復と依存整理 su-its/typing#249

Merged

cursor bot mentioned this pull request Apr 11, 2026

chore(deps-dev): bump eslint from 9.39.4 to 10.2.0 devandapaige/pythoness-programmer#38

Closed

ijstokes approved these changes Apr 12, 2026

View reviewed changes

This was referenced Apr 13, 2026

eslint-config-fluid: Switch from eslint-plugin-react to @eslint-react to unblock ESLint 10 microsoft/FluidFramework#27009

Closed

feat(eslint-config-fluid): switch from eslint-plugin-react to @eslint-react/eslint-plugin microsoft/FluidFramework#27011

Merged

danielhjacobs mentioned this pull request Apr 14, 2026

build(deps-dev): bump eslint from 9.39.3 to 10.0.3 ruffle-rs/ruffle-rs.github.io#529

Merged

danielhjacobs mentioned this pull request Apr 15, 2026

Compatibility with ESLint 10 import-js/eslint-plugin-import#3227

Open

ParcostaBot mentioned this pull request Apr 17, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.2.0 Parcosta/c2c-website#84

Closed

charles4221 mentioned this pull request Apr 20, 2026

Upgrade to ESLint v10 FortAwesome/react-fontawesome#640

Open

9 tasks

charles4221 linked an issue Apr 20, 2026 that may be closed by this pull request

Upgrade to ESLint v10 FortAwesome/react-fontawesome#640

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979

Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979
ledsun wants to merge 2 commits intojsx-eslint:masterfrom
ledsun:update-deprecated-calls-v8

ledsun commented Feb 9, 2026 •

edited

Loading

Uh oh!

ljharb left a comment

Uh oh!

codecov bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karlnorling commented Mar 2, 2026

Uh oh!

ledsun commented Mar 17, 2026 •

edited

Loading

Uh oh!

Guymestef commented Mar 25, 2026

Uh oh!

socket-security bot commented Mar 29, 2026 •

edited

Loading

Uh oh!

ljharb commented Apr 1, 2026

Uh oh!

ijstokes left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

ledsun commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karlnorling commented Mar 2, 2026

Uh oh!

ledsun commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Guymestef commented Mar 25, 2026

Uh oh!

socket-security bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb commented Apr 1, 2026

Uh oh!

ijstokes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

8 participants

ledsun commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited

Loading

ledsun commented Mar 17, 2026 •

edited

Loading

socket-security bot commented Mar 29, 2026 •

edited

Loading