Skip to content

Update types and RuleContext deprecations #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tylermumford wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Draft

Update types and RuleContext deprecations #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/jsx-filename-extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module.exports = {
},

create(context) {
const filename = context.getFilename();
const filename = context.filename;
Copy link
Copy Markdown
Member

@ljharb ljharb Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably safer to do this since we still support much older eslint versions?

Suggested change
const filename = context.filename;
const filename = context.filename || context.getFilename();


let jsxNode;

Expand Down
2 changes: 1 addition & 1 deletion lib/util/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function resetDetectedVersion() {

function resolveBasedir(contextOrFilename) {
if (contextOrFilename) {
const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.getFilename();
const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename;
Copy link
Copy Markdown
Member

@ljharb ljharb Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename;
const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename || contextOrFileName.getFilename();

const dirname = path.dirname(filename);
try {
if (fs.statSync(filename).isFile()) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@babel/plugin-syntax-do-expressions": "^7.27.1",
"@babel/plugin-syntax-function-bind": "^7.27.1",
"@babel/preset-react": "^7.27.1",
"@types/eslint": "=7.2.10",
"@types/eslint": "=8.56.12",
Copy link
Copy Markdown
Member

@ljharb ljharb Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still support eslint 7 so i'm not sure we can upgrade the types - and if we do we'd use ^, not =

Copy link
Copy Markdown

@ipanasenko ipanasenko Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump major and drop eslint7 support?

"@types/estree": "0.0.52",
"@types/node": "^4.9.5",
"@typescript-eslint/parser": "^2.34.0 || ^3.10.1 || ^4 || ^5 || ^6.20 || ^7.14.1 || 8.4 - 8.17",
Expand Down
Loading