new rule: padding-lines-between-tags #3554#3789
Draft
etherealm13 wants to merge 3 commits intojsx-eslint:masterfrom
Draft
new rule: padding-lines-between-tags #3554#3789etherealm13 wants to merge 3 commits intojsx-eslint:masterfrom
etherealm13 wants to merge 3 commits intojsx-eslint:masterfrom
Conversation
etherealm13
changed the title
padding-lines-between-tags: add rule and test cases
Author
|
@ljharb Let me know your thoughts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3789 +/- ##
==========================================
- Coverage 97.75% 97.19% -0.57%
==========================================
Files 135 136 +1
Lines 9715 9789 +74
Branches 3527 3553 +26
==========================================
+ Hits 9497 9514 +17
- Misses 218 275 +57 ☔ View full report in Codecov by Sentry. |
ljharb
requested changes
Jul 22, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
A few changes, but in particular, it would need thorough tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3554 Rule to disallow blank lines between tags
Based on https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/padding-line-between-tags.js