Conversation
Dark mode now uses Bootstrap's native data-bs-theme attribute instead of the parallel data-theme hook. Bootstrap themes its own components (inputs, placeholders, tables, dropdowns, modals), so most of the hand-written dark override block is replaced by theme tokens plus a few brand overrides. - Fix unreadable dark-mode search results header: Bootstrap does not darken the .table-secondary contextual variant, leaving light text on a light background, so its cells are now themed explicitly. - Fix dark-mode search input placeholder (was dark-on-dark) and map alerts onto Bootstrap's dark subtle palette instead of light strips. - Theme the health "refresh period" strip (was a hardcoded inline light blue). - Accessibility: associate the login labels with their inputs (for/id mismatch), label the search and tag inputs, and name the logout and branding links. - Markup: remove the duplicate id="menu" wrapper in the common layout.
- Coherent type scale for the top nav and page headings; nav items vertically centred in the header. - Nav links get a padded, rounded hover pill. - Brand palette reworked as tokens (refined indigo, softer neutral surfaces, distinct dark header); health refresh strip re-toned to match. - Search toolbar: spaced buttons, green Search action, compact Options button. - Tag input styled as a Bootstrap form control; footer no longer clips it. - Pane resizer fixed (panes now take explicit heights) and given a larger grab area. - Wide data tables scroll inside their container on small screens.
Author
|
This is a superset of the other PR: #508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This brings together two related pieces of work on the web UI: a correctness fix for dark mode and accessibility, and a visual refresh. It is kept as two commits so they can be reviewed or merged separately if preferred.
Part 1, dark mode and accessibility:
data-bs-themeattribute instead of a separatedata-theme, so Bootstrap themes its own components from the--bs-*variables. The hand written override block inassets/css/piler.cssis mostly gone..table-secondaryvariant, which left light text on a light background.for="floatingInput"andfor="floatingPassword"and did not match the input ids.id="menu"wrapper in the common layout.Part 2, visual refresh:
Verification
labels === ["Email address"].Notes
webui/tree is identical between thepiler-1.4.9tag andmaster.Screenshots before and after
Some examples of the changes:
Login before/after (dark)


Preview before/after (light)


Preview before/after (dark)

