Repository navigation
postinstall: fix key size check to match KEYLEN - #498
Merged
Merged
Conversation
make_new_key() writes 56 bytes with dd but checks for 64, so the condition can never be satisfied and postinstall always aborts with 'could not read 64 bytes from /dev/urandom'. With set -o errexit it exits before chgrp and chmod, leaving the key as root:root 644. 56 is the correct size: src/config.h defines KEYLEN 56, cfg.h declares key[KEYLEN], and store.c reads exactly KEYLEN bytes. Writing 64 would add 8 bytes the daemon never reads. The earlier version of the function wrote to $KEYTMPFILE and checked for 56; the size appears to have been changed to 64 when it was reworked to write straight to $KEYFILE.
jsuto
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_new_key() writes 56 bytes with dd but checks for 64, so the condition can never be satisfied and postinstall always aborts with 'could not read 64 bytes from /dev/urandom'. With set -o errexit it exits before chgrp and chmod, leaving the key as root:root 644.
56 is the correct size: src/config.h defines KEYLEN 56, cfg.h declares key[KEYLEN], and store.c reads exactly KEYLEN bytes. Writing 64 would add 8 bytes the daemon never reads.
The earlier version of the function wrote to $KEYTMPFILE and checked for 56; the size appears to have been changed to 64 when it was reworked to write straight to $KEYFILE.