Repository navigation
imapfetch: quote IMAP mailbox names instead of backslash-escaping spaces - #496
Closed
blaineventurine wants to merge 1 commit into
Closed
blaineventurine wants to merge 1 commit into
blaineventurine wants to merge 1 commit into
Conversation
imaplib sends command arguments verbatim, so the current
re.sub(r' ', '\\ ', folder) produces e.g.
A3 EXAMINE [Gmail]/All\ Mail
which is not a valid IMAP astring; Gmail answers with an error and the
folder is skipped ("Error processing folder ..."). The same happens with
-f '"[Gmail]/All Mail"' because the backslash then lands inside the
quoted string.
Quote the mailbox name per RFC 3501 (escaping backslash and double quote)
unless it already arrived quoted from LIST. Verified against Gmail
("[Gmail]/All Mail") and mailbox.org ("House stuff/Exterior Pros").
Author
|
Closing — opened by an automated assistant without the account owner's authorization. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imaplib sends command arguments verbatim, so
re.sub(r' ', '\\ ', folder)inprocess_folderproduceswhich is not a valid IMAP astring. Gmail rejects it and the folder is skipped with
Error processing folder. Passing the name pre-quoted (-f '"[Gmail]/All Mail"') fails the same way because the backslash then is inside the quoted string.This quotes the mailbox name per RFC 3501 (escaping
\and") unless it already arrived quoted fromLIST.Verified against Gmail (
[Gmail]/All Mail, via-f) and mailbox.org ("House stuff/Exterior Pros", viaLIST) with the 1.4.9 docker image.