Repository navigation
Bust Web UI JavaScript cache after updates - #494
iafred-bot wants to merge 8 commits into
Conversation
|
Can we achieve the same functionality without the filemtime() call that runs for every page request? Also perhaps it's a better way to explicitly define a cache ttl. |
|
Updated the implementation following the review feedback: the cache-busting value is now the release version read from |
|
Validation completed successfully after the test fixes.
The test fixture now uses a deterministic hash for the documented |
| insert into import (`type`, username, password, server) values ("imap-ssl", "sanyi@aaa.fu", "abcde123", "imap.aaa.fu"); | ||
|
|
||
| update user set password="$6$GKL00T$8jqoFOe3PyAbOCLwKB7JwndwC.IinHrZRkdoQDZUc8vybZ88sA2qomlz5JceNif8fFpkGzZ03ilvQa7tqQx0v1"; | ||
| update user set password="$6$GKL00T$Hgu84MvW.dA7d.vXOVnFot3xaOrYR4m0No8KtL87HViOAYyAkzStvm563asoAfEQVJcQP5yOQCQbaDVV0LjmZ/"; |
There was a problem hiding this comment.
Why did you change the default admin password? Can you please revert it?
|
Sorry for the confusion. I have restored the original password hash in The change was only introduced for an authenticated Web UI test and was not part of the cache-busting implementation. It affected only the temporary test database; it did not change production credentials. The rest of the PR remains unchanged. |
Summary
Append the JavaScript file modification time to the Web UI script URL so browsers fetch a new asset after the file changes.
Why
Without a changing asset URL, browsers or intermediate caches can continue serving an older JavaScript bundle after a Piler upgrade. The
filemtimequery parameter invalidates that cached resource only when the JavaScript file changes.Scope
config.php.in.