Skip to content

Run the tests on GitHub Actions - #8

Merged
jpm merged 4 commits into
masterfrom
ci/github-actions
Nov 10, 2026
Merged

jpm merged 4 commits into
masterfrom
ci/github-actions

Conversation

@jpm

@jpm jpm commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Step 6 of the unit testing plan. Stacked on #7.

Commits

  1. Reject, rather than crash on, Phorum crypt passwords with odd salts. Phorum uses the first characters of the password as the DES salt, and glibc's crypt() raises OSError for salt characters outside [a-zA-Z0-9./] (macOS accepts them). So on Linux, a login with a password like !secret raised an exception instead of being rejected. Found by running the suite in Docker on Linux.
  2. Test Phorum crypt/MD5 logins, and add standard-crypt to the dev requirements (crypt left the stdlib in 3.13).
  3. Add .github/workflows/tests.yml: unit tests on Python 3.10 to 3.15, with a coverage report as an artifact.

Testing

  • Locally (macOS, 3.15): 363 passed, 5 skipped, 1 xfailed; coverage 80%.
  • In Docker (Linux): the full suite passes on 3.10, 3.13 and 3.14.
  • This PR's own CI run is the test of the workflow.

jpm added 4 commits November 10, 2026 06:06
Phorum uses the first characters of the password as the DES salt, and
glibc's crypt() raises OSError for salt characters outside [a-zA-Z0-9./]
(macOS accepts them). A login with a password like '!secret' raised an
exception instead of being rejected.
The Phorum auth modules import crypt, which left the standard library
in Python 3.13.
Step 6 of docs/unit-testing-plan.md: unit tests on Python 3.10 to 3.15,
with a coverage report uploaded from the 3.13 run.
checkout@v4, setup-python@v5 and upload-artifact@v4 target Node.js 20,
which GitHub is retiring.
@jpm
jpm changed the base branch from tests/forwarding-proxy to master November 10, 2026 12:54
@jpm
jpm merged commit 5b8429d into master Nov 10, 2026
6 checks passed
@jpm
jpm deleted the ci/github-actions branch November 10, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant