Repository navigation
Run the tests on GitHub Actions - #8
Merged
Merged
Conversation
Phorum uses the first characters of the password as the DES salt, and glibc's crypt() raises OSError for salt characters outside [a-zA-Z0-9./] (macOS accepts them). A login with a password like '!secret' raised an exception instead of being rejected.
The Phorum auth modules import crypt, which left the standard library in Python 3.13.
Step 6 of docs/unit-testing-plan.md: unit tests on Python 3.10 to 3.15, with a coverage report uploaded from the 3.13 run.
checkout@v4, setup-python@v5 and upload-artifact@v4 target Node.js 20, which GitHub is retiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 of the unit testing plan. Stacked on #7.
Commits
crypt()raisesOSErrorfor salt characters outside[a-zA-Z0-9./](macOS accepts them). So on Linux, a login with a password like!secretraised an exception instead of being rejected. Found by running the suite in Docker on Linux.standard-cryptto the dev requirements (cryptleft the stdlib in 3.13)..github/workflows/tests.yml: unit tests on Python 3.10 to 3.15, with a coverage report as an artifact.Testing