Repository navigation
Fix LISTGROUP and XROVER; log only command names - #10
Merged
Merged
Conversation
- LISTGROUP: ''.split('\r\n') is [''], so an empty group made '' the
current article instead of clearing it, and the empty list was sent as
one blank line. XHDR had the same blank-line problem.
- XROVER overwrote its range argument with the header name (and raised
IndexError without one), and XHDR only accepted SUBJECT and FROM, so
XROVER always returned 501. XHDR now also accepts REFERENCES.
Reachable now that XROVER works: like XOVER before it, XHDR used the topic id as the replied-to article number, and gave every post a reference, including the first post of each topic.
Every line a client sent was written to the log, including the full
text of posted articles, search patterns, group names and login names
(passwords were already filtered). Requests are now logged by command
name only ('unknown command' for anything else), and article lines are
not logged at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
''.split('\r\n')is[''], so an empty group made''the current article instead of clearing it, and the empty list was sent as one blank line. XHDR had the same blank-line problem.IndexErrorwithout one), and XHDR only acceptedSUBJECT/FROM, so XROVER always returned 501. XHDR now also acceptsREFERENCES.unknown commandfor anything else), and article lines aren't logged.These were the last two known bugs in
docs/unit-testing-plan.md; the suite no longer has any expected failures.Testing