Skip to content

Fix LISTGROUP and XROVER; log only command names - #10

Merged
jpm merged 3 commits into
masterfrom
fix/listgroup-xrover
Nov 10, 2026
Merged

jpm merged 3 commits into
masterfrom
fix/listgroup-xrover

Conversation

@jpm

@jpm jpm commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Commits

  1. Fix LISTGROUP on empty groups, and XROVER.
    • LISTGROUP: ''.split('\r\n') is [''], so an empty group made '' the current article instead of clearing it, and the empty list was sent as one blank line. XHDR had the same blank-line problem.
    • XROVER overwrote its range argument with the header name (and raised IndexError without one), and XHDR only accepted SUBJECT/FROM, so XROVER always returned 501. XHDR now also accepts REFERENCES.
  2. Fix XHDR REFERENCES in the phpBB and PHP-Nuke backends. It became reachable through XROVER, and had the same topic-id bug as their XOVER: every post got a reference, including first posts, and posts referenced articles in other topics.
  3. Log only the command names of requests. Every line a client sent used to be logged, including the full text of posted articles, group names, search patterns and login names. Now each request logs just its command name (unknown command for anything else), and article lines aren't logged.

These were the last two known bugs in docs/unit-testing-plan.md; the suite no longer has any expected failures.

Testing

  • In Docker: 497 passed, 5 skipped (all unit and integration tests).
  • Against the old code: the new protocol tests fail (6 for LISTGROUP/XROVER/XHDR, 4 for logging), and the phpBB/PHP-Nuke XROVER integration tests fail.

jpm added 3 commits November 10, 2026 09:45
- LISTGROUP: ''.split('\r\n') is [''], so an empty group made '' the
  current article instead of clearing it, and the empty list was sent as
  one blank line. XHDR had the same blank-line problem.
- XROVER overwrote its range argument with the header name (and raised
  IndexError without one), and XHDR only accepted SUBJECT and FROM, so
  XROVER always returned 501. XHDR now also accepts REFERENCES.
Reachable now that XROVER works: like XOVER before it, XHDR used the
topic id as the replied-to article number, and gave every post a
reference, including the first post of each topic.
Every line a client sent was written to the log, including the full
text of posted articles, search patterns, group names and login names
(passwords were already filtered). Requests are now logged by command
name only ('unknown command' for anything else), and article lines are
not logged at all.
@jpm
jpm merged commit d12e92e into master Nov 10, 2026
7 checks passed
@jpm
jpm deleted the fix/listgroup-xrover branch November 10, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant