Repository navigation
Conversation
List double-clicks canceled the delayed click-to-rename, but grid and keyboard activation did not. Cancel at the common activation entry point so the delayed editor cannot refocus Ferail after opening a document. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-clicking the label of a selected grid item can open its application and then start an inline rename, pulling focus back to Ferail. Only the list double-click handler canceled the delayed rename.
Cancel it in the common activation path so grid and keyboard activation behave the same way. Verified with a dummy ODT document: Writer opens and the delayed editor no longer appears. The inline-edit tests and Clippy pass.
Before:
After: