Repository navigation
Conversation
Expose the primary Trash in Locations, restore original paths from standard trash metadata without overwriting collisions, and clean sidecar metadata when emptying or deleting trashed items. Run filesystem work on the existing workers. Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
ooonea
marked this pull request as draft
November 1, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the primary freedesktop Trash to Locations. Restore items from the selected item's metadata without replacing an existing destination, and remove metadata when emptying the Trash or permanently deleting an item. All filesystem work runs on the existing workers.
Keep filename bytes intact, tolerate unrelated metadata lines, and reject malformed metadata or symlinked Trash directories. Unrelated broken entries do not prevent restoring a valid item.
Depends on #18. Rebase after it merges, adapting the Trash row to the Linux XDG resolver, before marking this PR ready for review.
The isolated native regressions cover restore collisions, metadata cleanup, filename bytes and symlink handling. The filesystem tests and Clippy pass.