Repository navigation
Conversation
Use GPUI’s cached portal appearance instead of spawning gsettings. Follow native appearance changes for open windows while preserving explicit light/dark selections and startup overrides. Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System theme falls back to light when GSettings schemas are unavailable, even when the desktop portal reports dark. Use GPUI’s cached appearance and observe native appearance changes while System is selected.
Synchronize the palette when each window opens so an early portal reply cannot leave the initial theme stale. Avoid reapplying an unchanged theme.
Verified in an isolated Linux session with a deliberately stale initial palette: System adopts the window's dark appearance, explicit Light stays light, and opening another window preserves the UI scale.