Repository navigation
Conversation
Render the first page on a thumbnail cache miss using pdftoppm. Detect PDFs by their header and return the image to the existing preview, grid and viewer caches without writing nonstandard freedesktop thumbnails. Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux cannot render a PDF preview on a cache miss with GdkPixbuf alone. Render the first page with Poppler when available, and keep PDF bytes out of the text preview.
Limit the renderer's runtime and captured output so a stalled helper does not hold up preview workers.
Tested real Poppler rendering of an extensionless PDF with spaces in its path, plus timeout and child reaping when the renderer stalls. The native text-preview regressions pass.