Repository navigation
style: apply the signature layout - #36
Merged
Merged
Conversation
Reformat col-0 declarations to the diff-minimizing layout: name alone on the keyword line, one binder group per line, leading colon on the ascribed type. Whitespace only.
Recompute the signature-layout pass with the fixed converter: binder defaults in brackets no longer truncate the header, `do` bodies are no longer misread as one-liners, anonymous `instance : T where` now converts, and single-operand headers with no binders stay on one line instead of splitting for nothing. The `do`-body fix reaches roughly a hundred declarations across the REPL and SystemOnTPTP modules that the buggy pass had skipped outright. Properties/Basic.lean and test/Tests.lean revert to base: their only touched declarations were pure churn under the last bug.
jonaprieto
force-pushed
the
style/signature-layout
branch
from
September 18, 2026 21:16
e380baa to
98c6c45
Compare
Move a trailing := / := by off the ascribed type's last line onto its own line at indent 4, matching the bare := shape.
Treat := do like := by so those declarations convert too, hoist attributes above the keyword line, and split any multi-line header in full, not just ones with binders.
jonaprieto
marked this pull request as ready for review
September 19, 2026 04:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.