Queue the FTDI test reply at the JTAG call. - #71
Merged
Merged
Conversation
The endpoint-sharing test preloaded a JTAG reply which the fake released on the preceding write-only SWD call. The receive goroutine could reject that unsolicited payload before JTAG started, intermittently poisoning the channel. Queue the reply after SWD returns, check that the write-only call completed no USB reads, and verify the JTAG sample. This corrects the test fixture while preserving the channel's unsolicited-payload guard.
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the intermittent failure in
TestWireMethodsShareEndpointby queuing the fake JTAG reply after the preceding write-only SWD call returns. The test now checks that SWD completed no USB reads and that JTAG returned the expected sample. The change is confined to the test fixture; production channel behavior and its unsolicited-payload guard are unchanged.Why
The fake releases queued replies on the next USB write. Preloading the JTAG reply let the earlier SWD write release it before JTAG had a pending response. Depending on goroutine timing, the receive path could report “received payload without a pending response” and poison the channel. Queuing the reply at the JTAG call makes the fixture match the exchange it is testing.
Documentation
No public API, ownership, or hardware behavior changes. The existing FTDI documentation remains accurate.