Repository navigation
Make the zoned types' compareTo match the JDK's - #21
Merged
Merged
Conversation
ZoneOffset sorted ascending where the JDK orders by descending total seconds, so a sort of offsets came out reversed. ZonedDateTime and OffsetDateTime compared by the instant's sign only; they now follow the JDK: epoch second, nano difference, local date-time, and for ZonedDateTime the zone id. Every compareTo also casts its argument, so another type is a ClassCastException instead of an NPE or an answer of 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZoneOffset sorted ascending where the JDK orders by descending total seconds,
so a sort of offsets came out reversed. ZonedDateTime and OffsetDateTime
compared by the instant's sign only; they now follow the JDK: epoch second, nano
difference, local date-time, and for ZonedDateTime the zone id. Every compareTo
also casts its argument, so another type is a ClassCastException instead of an
NPE or an answer of 1.