Repository navigation
Send eval errors in JVM nREPL's shape - #11
Merged
Merged
Conversation
On a jolt whose evaluate returns :err-msg/:ex-class/:root-ex-class, the session worker now sends err in clojure.main/err->msg form, ex and root-ex as class strings with eval-error, and done on its own message, as JVM nREPL does. The worker's own catch path renders through jolt.nrepl/err->msg when it exists. Older jolt keeps the message-only shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to jolt-lang/jolt#1323, which has
jolt.nrepl/evaluatereturn the error the way JVM nREPL sends it (:err-msg,:ex-class,:root-ex-class, plusjolt.nrepl/err->msg).The session worker forwards those:
errin clojure.main/err->msg form,ex/root-exas class strings with eval-error, then done on its own message. The worker's own catch path renders througherr->msgwhen it exists. On a jolt without those keys the old message-only shape is kept, so this works on 0.8.21 as before (the new tests skip there).Tests: the eval-error shape, a reader error with no stale trace, and output from realizing a lazy result reaching the client. Full suite passes against #1323 (78 tests) and against released 0.8.21.