Repository navigation
Timer cancel follow-ups, SIGPIPE in children, java.time and File(URI) fixes - #1199
Merged
Merged
Conversation
The wait cancelled its deadline on any raise passing through, so a handler further out that resumed the raise left the fiber parked with nothing to wake it at the deadline. The handler now re-arms when the raise comes back. Also drops the duplicate may-park! call and fixes a stale test comment.
Chez ignores SIGPIPE, and an ignored disposition survives exec, so every child inherited it: yes | head printed Broken pipe from yes instead of dying of the signal. posix_spawn now resets it with POSIX_SPAWN_SETSIGDEF, as the JVM's children get. Fixes #1196.
LocalDate/of, LocalDateTime/of, YearMonth/of, MonthDay/of and Year.atMonth all have Month overloads on the JDK; here a Month threw ClassCastException. The zone half of #1197 (ofInstant, ofEpochSecond's offset) is in jolt-lang/time.
All three took the URI's string as the path, so file:///tmp/a%20b became the relative path file:/tmp/a%20b. They decode the path now and reject what the JDK rejects, with its messages. io/file of a URI goes through the URL reading, as clojure.java.io does. Fixes #1198.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #1195 plus three reported issues.
Spawned children inherit SIG_IGN for SIGPIPE (bb/JVM resets it in children)#1196). Chez ignores SIGPIPE and the ignore survived exec, soyes | headprinted Broken pipe.ofand Year.atMonth accept a Month (java.time.LocalDateTime: ofInstant is missing; ofEpochSecond ignores its offset#1197). The zone half (LocalDateTime/ofInstant, ofEpochSecond's offset) is LocalDateTime/ofInstant, and ofEpochSecond applies its offset time#18, since core has no zones.java.io.File(URI), Paths.get(URI) and Path.of(URI) keep the URI string as the path#1198). io/file of a URI goes through its URL, as clojure.java.io does.Fixes #1196, fixes #1198.