Repository navigation
Reset per-report state when reusing a Speedscope renderer - #466
Merged
joerick merged 1 commit intoOct 12, 2026
Merged
Conversation
AI assistance: OpenAI Codex was used for investigation, implementation, regression tests, and automated validation.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a SpeedscopeRenderer carries its event clock and frame-index table into the next report. A second 0.25-second session can emit events from 0.25 to 0.5 while its declared endValue remains 0.25; distinct or empty sessions also retain unrelated frames.
Reset both pieces of per-report state at the start of render. Recursive render_frame calls retain their shared state within that report. Tests compare reused and fresh renderers for identical, different and empty sessions.
Validation on CPython 3.12/Linux:
Other interpreter/OS combinations and hosted CI have not run locally.
AI assistance: OpenAI Codex was used to investigate, implement and test this fix. No human review is claimed.