Repository navigation
Start one pipeline in the Pages unpublish scenario, so no deployment lands after the unpublish - #1094
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: jmrplens/gitlab-mcp-server/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The fix for #945 (#948) removed the workflow's own `actions/cache` step for `~/.cache/golangci-lint` and left a second cache of that directory in place: `golangci-lint-action` keeps one itself. `install-only: true` returns after the install and nowhere else, so the action still restores that cache before installing (`run()` calls `restoreCache` first) and saves it again in its post step, under `golangci-lint.cache-<os>-<interval>-<go.mod hash>` keys. The comment in `ci.yml` said the cache was not restored and the static analysis page that it was not kept between runs, and neither was true. On 2026-09-30 the lint of #1088 to #1094, opened minutes before, reported fifty unused `//nolint:staticcheck` directives on each layer, in files the stack does not touch. Every one of those jobs restored, by exact key, the entry main's push run of b44ab96 had saved at 09:07 UTC: the key names only the OS, a seven-day interval and the hash of `go.mod`, which the stack shares with main, so the analysis of main's tree matched a different tree exactly. With that entry deleted, #1087's second run and a rerun of #1088's commit fell back through the restore key to main's entry of 2026-09-25 and linted clean, and a cold `make golangci-lint` of the stack's tip reports nothing. That is the failure #945 describes, a restored analysis disagreeing with the tree, coming from the cache #948 did not see, and this time from main's entry rather than the pull request's own. `skip-cache: true` turns off both the restore and the save. The comment above the step now says why it is needed alongside `install-only` and what the key leaves out, and `docs/development/static-analysis.md` says the same. The job's header comment no longer says the action caches the linter binary, which it downloads on every run. The Go build and module caches setup-go keeps are unaffected. What it costs, measured on the whole job as #945 asks: the eight pushes to main between 29 September 11:27 and 30 September 09:02 UTC each restored a cache and took 214 to 319 s, the `make golangci-lint` step 190 to 298 s of it; this pull request's run, the only one with the change so far, restored nothing and took 313 s, the step 287 s. All eight restored the entry main saved on 25 September, which the action does not save again while its key still matches, so the analysis they reused was of a tree days older than theirs: it was not buying time the spread between runs can show. Closes #945
a5401f1 to
5316d5c
Compare
… unpublish TestPages_Unpublish_RemovesTheDeployment committed its Pages configuration to the default branch and then created a pipeline, so every project ran two: the push started one and the fixture the other, which is why the pipelines the three surfaces waited for were 33, 35 and 37. Both run the pages job, and both deploy. The wait for a deployment was therefore met by whichever deployment came first. On the meta surface of a CE run on GitLab 19.4.1 the unpublish and the read after it completed within 200 ms of the read that met the wait, and that last read still listed a deployment created in the same second: the other pipeline's, deployed after Pages::DeleteService had deactivated every active one. The other two surfaces passed on the same run. The configuration is now committed with [skip ci], as the model evaluation's worlds already commit theirs, so the pipeline the fixture creates is the only one and its deployment is the one the wait sees. GitLab ignores the marker for a pipeline created through the API (Ci::CreatePipelineService is called with ignore_skip_ci there).
The Pages scenario's comment moves the README's end-to-end line count. Every other generator, the request inventory recorded through the whole unit suite among them, came out unchanged.
…e stack Both complete Docker runs of e600a73d0 passed with no skip, the licensed one on GitLab 19.4.1-ee (1332 tests) and the unlicensed one on 19.4.1 (1067 tests), and this records them. The levels are the ones the record already held (CE L1 834 of 872, L2 730, L3 714; EE L1 1028 of 1092, L2 924, L3 908); the test calls grow to 3524 and 4671, and every package entry now names the commit and run it came from.
The HTTP routing section of CLAUDE.md opened with "Nine invariants" over eight top-level bullets: main said six over seven, and the held-call bullet this stack added moved the figure by three rather than one. .github/skills holds 18 skill directories and CLAUDE.md's skills table has 18 rows, while the project structure, the table's heading and the Copilot instructions all said 19. No link targets the heading's anchor.
The loopback helper, the fairness driver's input struct and the executable name helper moved the source, function, comment and struct counts, and the entry #1086 added to the documentation audit's allowed names one source line, which also mentions gitlab. Their tests and the two bench_resources tests held to their values rather than the host moved the unit-test line count. The shared flood and the listing arm judged where it crossed moved the end-to-end line count, and the flood's two defers the defer count. serverExecutable's test adds one test function to the testing reference.
5316d5c to
f98733c
Compare
A refusal of HLD-010 or HLD-011 establishes only that the process is full. One credential can fill HLD-010 by itself, and HLD-011 where the descriptor limit is small or the rate limit is off, and the refusal names no figure, so it does not show that other callers hold slots: a caller can conclude that only from its own count, plainly when it holds none. The INV-019 paragraph now says so, and its lead sentence draws the inference that others are holding only where a caller is still under a bound of its own or knows the upstream to be healthy, which leaves these two rows out. ADR-0023 NEG-007 calls their refusal at most the same bit, and the comment on the session refusal in cmd/server no longer says that words naming the ceiling would tell a caller others hold sessions. A systemd unit without a MemoryMax of its own is still bounded by the MemoryMax of the slices above it, since cgroup v2 applies the memory.max of every ancestor. Every page, register comment and code comment that said such a unit is bounded only by the host now says so, in English and Spanish, and the operator guides name `systemctl show -p EffectiveMemoryMax <unit>`, which reports the tightest of those limits on systemd 256 and later and prints nothing on earlier versions. The README statistics move with the four comment lines this adds.
|
GitHub skips every workflow a push triggers when the commit the push lands on carries a skip command anywhere in its message, and it reads the command inside backticks as readily as in plain text. This repository squash merges, so the pull request description becomes that message. The description of #1094 explained a Pages fixture that commits with the first of those commands, and quoted it. Its merge, 7baa4a4, therefore ran no CI, no CodeQL, no GitLab mirror and no Pages deployment on main (I dispatched the mirror and Pages by hand; the other two have no manual trigger), and the v3.1.0 tag later put on that commit started no release. ## What changes - `scripts/check-em-dash.sh description`, which `make check-pr-description` runs on every pull request, now refuses the five bracketed commands GitHub documents for push and pull_request events (skip ci, ci skip, no ci, skip actions and actions skip, each in square brackets) in the title or the body, in any case, with any spacing inside the brackets and inside backticks. It also refuses the other form GitHub documents, a skip-checks trailer set to true, at the start of any line of the body, indented or in backticks included: any line rather than the last, since the description is not the end of the squash commit's message and where GitHub honours the trailer is not something to rely on, and only at the start, so a sentence can still name it. Every body grep reads its input as text, so a byte that is not valid UTF-8 in a body read from disk cannot make a line pass unjudged. The refusal names the line and says to write the command without its square brackets, which is enough to talk about it. - The description mode had no tests. `scripts/check_em_dash_sh_test.py` runs the real script over titles and bodies written to disk (the rehearsal path it already offers): each command in the body, one in the title, mixed case, spacing and backticks, the trailer in each spelling and before another trailer, a command beside a byte invalid in UTF-8, the bare words and a mid-sentence trailer passing, and the em dash and injected-block refusals still holding, all reported in one run. One case drives the path CI takes, `PR_NUMBER` through `gh api` and `jq`, against a stand-in `gh` answering with a body in CRLF, and one runs shellcheck on the script. CI's script-test step picks the file up by its name pattern. - The Makefile target's comment, the two CI comments (the script-test step and the description step), `docs/development/static-analysis.md`, `CONTRIBUTING.md` and the header of `CLAUDE.md` say what the gate now refuses and why. ## What it does not cover Only a pull request description is read. What reaches main without one is not: the release job's manifest stamp, whose message `release.yml` fixes and which carries no skip command, and a direct push by an administrator through the main ruleset's bypass. ## Verification - `python3 -m unittest discover -s scripts -p 'check_em_dash_sh_test.py'`: 14 tests pass, and the whole script suite with them. - `shellcheck` and `bash -n` on the script; `make check-em-dash` against `origin/main`; `go run ./cmd/format_md_tables/ --check`; `markdownlint-cli2` on the changed pages; `gen_stats -check`. - This description, and the commit message, pass the gate they add.



The complete CE run of this stack's top (47ad92602, the issue-951-decisions head before the stack was rebased onto b44ab96; GitLab 19.4.1) failed one end-to-end scenario, and the failure is neither in the server nor in anything this stack changes:
TestPages_Unpublish_RemovesTheDeploymentraced its own second pipeline. This layer, the new top of the stack, fixes the scenario.Two pipelines deployed every site
The scenario commits a Pages configuration to the default branch and then creates a pipeline, so every project ran two: the push started one and the fixture the other, which is why the pipelines the three surfaces waited for were 33, 35 and 37. Both run the
pagesjob, and both deploy the site.The wait for a deployment was therefore met by whichever deployment came first. On the meta surface, the unpublish and the read after it completed within 200 ms of the read that met the wait, and that last read still listed a deployment created in the same second: the other pipeline's, deployed after
Pages::DeleteServicehad deactivated every active one. The dynamic and individual surfaces passed on the same run, and the same scenario passed on the stack's earlier Docker runs.The fix
deployPagesnow commits the configuration with[skip ci], as the model evaluation'scommitCIConfigurationalready commits the configurations of the worlds it builds, so the pipeline the fixture creates is the only one and its deployment is the one the wait sees. GitLab ignores the marker for a pipeline created through the API (lib/api/ci/pipelines.rbcallsCi::CreatePipelineServicewithignore_skip_ci: true), so that pipeline still runs. The push still records a pipeline of its own, in the skipped state and with no job (Gitlab::Ci::Pipeline::Chain::Skip), so each project still takes two pipeline IDs and the one the fixture waits for is every other one (32, 34 and 36 on the passing CE run, 33, 35 and 37 on the EE run). What the scenario holds is unchanged: a deployment exists before the unpublish, and after it the settings list none or the read is refused as not found.Other scenarios also commit a CI configuration and then create a pipeline through the API, so they run a second pipeline too: the job lifecycle, the resource group and the SAST report pipeline, and every scenario built on
fixture.CIFile. None of them reads anything the push's pipeline can change after its wait: the job reads are pinned to the created pipeline or resolved to the newest successful one, the resource group scenario asserts only the shape of what is queued, the SAST findings are read for the created pipeline's iid, and the pipeline lifecycle already accepts a latest pipeline no older than the one it created. None of them failed on these runs, and this layer leaves them as they are. The release job scenario is not one of them: its one job runs only on a tag, so the branch push starts nothing, and the tag pipeline it waits for runs on the commit that carries the configuration, where the marker would skip the only pipeline it has.Checks
make check-e2e-coverage-recordandmake check-e2e-coverage-pagepass.check-e2e-staticand the freshness checks were run again after it): it builds and vets (plain and under thee2e,httpe2e,stdioe2eandcollectore2etags), every e2e package compiles, and theserialtypecheckgate passes, under-racetoo; the whole unit suite passes shuffled (276 packages); every make target of CI's generated-artifacts job passes, withcheck-request-inventoryon a recording of the whole suite (1625 rows, unchanged);make golangci-lintandmake govulncheckreport nothing;test/e2e/httppasses (605 tests, the 7 Docker-only proxy and balancer cases skipped) andtest/e2e/stdiopasses (118 tests).e2e,httpe2e,stdioe2eandcollectore2etags), every e2e gitlab package compiles, the unit suites of the six packages the stack touches pass shuffled,make check-tenancyreads 83 rows and 308 sites, and the freshness gates CI runs pass: the README statistics, the llms files, the LobeHub manifest, the model evaluation corpus and results, the e2e coverage record and page, the token footprint, the site stats, the benchmark charts, the action catalog manifest, the testing reference, the request inventory and the golden snapshots.check-e2e-static,brand-check,check-install-buttons,check-doc-tool-names,check-doc-linksandcheck-plan-untrackedpass there too.CLAUDE.mdopened its HTTP routing section with "Nine invariants" over eight bullets (main says six over seven, and the held-call bullet this stack adds moved the figure by three), and said 19 skills in its project structure and its skills heading, as the Copilot instructions did, where.github/skillsholds 18 and the skills table lists 18. They now say eight and 18; no link targets the heading's anchor. markdownlint on both files,format_md_tables --check,check-em-dashagainstmainand the layer below,gen_stats -check,check-llms,check-doc-tool-names,check-doc-linksandaudit-catalog-first, which reads both files, pass.gen_stats -check,check-openplugin,check-doc-links,check-plan-untracked,check-mcpb, markdownlint on the changed pages,format_md_tables --checkandcheck-em-dashagainstmainpass, and the site-lint job's gates pass insite/.Review fixes from #1093
The two review threads on #1093 are answered here, at the top, so that no layer below is rebased for a wording change (9185eac):
HLD-010orHLD-011establishes.INV-019read a refusal of either as showing that other callers hold slots. It establishes only that the process is full: one credential can fillHLD-010by itself, andHLD-011where the descriptor limit is small or the rate limit is off, and the refusal names no figure, so a caller can conclude that others hold slots only from its own count, plainly when it holds none. The specification now says so, and its lead sentence draws the inference that others are holding only where a caller is still under a bound of its own or knows the upstream to be healthy, which leaves these two rows out. ADR-0023 NEG-007 now calls their refusal at most the same bit, and the comment on the session refusal incmd/server/sessions.gono longer says that words naming the ceiling would tell a caller others hold sessions; the register rows and the held-call refusal already stated only that the process is full.MemoryMaxis bounded only by the host was wrong for a unit whose slices set one, since cgroup v2 applies thememory.maxof every ancestor. They now say it is bounded by the slices above it where one of them sets one, and otherwise only by the host, in English and Spanish, and the operator guides namesystemctl show -p EffectiveMemoryMax <unit>, which reports the tightest of those limits on systemd 256 and later and prints nothing on earlier versions (checked on 252).Checked at 9185eac:
go test ./internal/tenancy, thecmd/serverbuild andmake check-tenancy(83 rows, 308 sites, 0 findings) pass through the remote runner; markdownlint on the changed pages,format_md_tables --check,gen_llms -check, the site stats check andgen_stats -check, after regenerating the README statistics for the four comment lines added, pass locally, and no em or en dash is added.Stack
Part of the tenancy stack for 3.1.0; no issue of its own. The other scenarios that start a second pipeline, and the fixtures the model evaluation shares with them, are recorded in #1096.