Repository navigation
feat(core): warn when a tier is below the cold-extrusion limit (ADR-0014) - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Custom (or edited) tower could have tiers below the firmware's minimum extrusion temperature with no warning; Klipper then stops the print (RPT-003).
ADR-0014: fixed limit
COLD_EXTRUSION_MIN_TEMPERATURE = 175°C, the highest stock default found (Prusa MK3S firmware 3.14.1: 175; Klipper, Marlin 2.1.2.5 and Buddy MK4: 170). Validation emitstemperature-below-cold-extrusion-limit(download stays reachable), the config form shows the same warning, and a fixture triggers it.Closes TSK-010.