Repository navigation
fix(core): reject a tower step that misses the top tier (ADR-0013) - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tierCountfloors|end - start| / step, so 230→228 step 5 gave a single tier and 230→190 step 15 never printed 190 °C, while the form and STL name said it would (RPT-004).ADR-0013: the end temperature is the top tier and is reached exactly.
validateTowerConfigrejects fewer than 2 tiers and a non-dividing step, naming the nearest reachable end temperatures. The config form lists the same problems. All presets stay valid (test added).Closes TSK-011.