Repository navigation
fix(core): wait with M109 S on Klipper (ADR-0012) - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Klipper reads only
SinM109, so the tier 0M109 R<t>set the hotend target to 0 °C and every transformed file stopped with "Extrude below minimum temp" (RPT-002).heaters.py/extruder.pyat0cee841e): the transform takes a temperature dialect fromgcode_flavor.klipper→ waiting tiersM109 S<t>(waits both ways on PID hotends); anything else keeps ADR-0010'sM109 R<t>..bgcode(flavor from metadata). Property tests run over both dialects and check the command shape.klipper-labelsgolden changes; every other golden is byte-identical.M109 R; the UI tells Klipper users to set the flavor.Closes TSK-009.