Repository navigation
fix(core): count one object for Klipper and OctoPrint-style labels - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single tower sliced with Klipper-flavour firmware labels or OctoPrint-style labels raised a false
multiple-objectserror, because the same object was collected in two forms (RPT-008).EXCLUDE_OBJECT_DEFINE NAME='<name>': quotes stripped.; printing object <name> id:<n> copy <n>: the full label is now kept, matchingobjects_info. Stripping the suffix instead (as the task text suggested) would merge real duplicates, which PrusaSlicer labelscopy 0/copy 1.slice-fixturesgainsflavorandlabelsvariant options; new real-slice fixturesklipper-labels,octoprint-labelsandklipper-multiple-objects. Existing goldens unchanged.Closes TSK-015.