Add Time Only Local and UTC Helpers by jmazur · Pull Request #49 · jmazur/go_transit_ruby

jmazur · 2026-09-14T20:44:35Z

The previous change added _utc/_local to every date and time field
across the gem except two families that are returned as a bare
"HH:MM", no date at all. Converting one of these to a real Time
requires knowing which calendar date it belongs to, and GO Transit's
own service date doesn't line up with calendar midnight: a service
date starting at 6am can run past 2am the next calendar day, and
every stop in that overnight tail still belongs to the original
service date, not the next one.

This change addresses the need by:

Adding a configurable service_day_boundary_hour (default 4) marking
where one service date ends and the next begins
Resolving _utc/_local for these fields by anchoring to a known
date rather than assuming "today", correctly handling a trip whose
very first stop is already past midnight with no other stop to
compare it against
Threading the anchor date through Schedule.trip and
Schedule.journey automatically, so no caller has to supply one
themselves

hound · 2026-09-14T20:44:42Z

+    def to_local_from_anchor(time, trip_date, timezone: "America/Toronto")
+      raise MissingAnchorDateError if trip_date.nil?
+      return nil if time.blank?
+      hour = time.split(":").first.to_i


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

+      to_local_from_anchor(time, trip_date, timezone: timezone)&.utc
+    end
+
+    def to_local_from_anchor(time, trip_date, timezone: "America/Toronto")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

      date.in_time_zone(timezone)
    end
+
+    def to_utc_from_anchor(time, trip_date, timezone: "America/Toronto")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

@@ -1,3 +1,3 @@
 module GoTransit
-  VERSION = "1.2.0".freeze
+  VERSION = "1.3.0".freeze


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

+      expect(GoTransit.service_day_boundary_hour).to eq(4)
+    end
+
+    it "can be overridden via configure" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit do
+  describe ".service_day_boundary_hour" do
+    it "defaults to 4" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit do
+  describe ".service_day_boundary_hour" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T20:44:42Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit do


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

hound · 2026-09-14T23:09:51Z

+    it "cascades the anchor date to both arrival_time and departure_time" do
+      stop = described_class.new(
+        "ArrivalTime" => { "Scheduled" => "14:50", "Computed" => "", "Status" => "" },
+        "DepartureTime" => { "Scheduled" => "14:54", "Computed" => "", "Status" => "" },


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [88/80]
Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call.

hound · 2026-09-14T23:09:51Z

+  describe "#anchor_date=" do
+    it "cascades the anchor date to both arrival_time and departure_time" do
+      stop = described_class.new(
+        "ArrivalTime" => { "Scheduled" => "14:50", "Computed" => "", "Status" => "" },


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [86/80]

hound · 2026-09-14T23:09:51Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop do
+  describe "#anchor_date=" do
+    it "cascades the anchor date to both arrival_time and departure_time" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:09:51Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop do
+  describe "#anchor_date=" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:09:51Z

@@ -0,0 +1,15 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop do


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

hound · 2026-09-14T23:09:51Z

+
+    it "propagates its own Date to every stop, across every service and trip" do
+      date = Date.parse("2023-03-13")
+      journeys = GoTransit::Schedule.journey(date: date, from_stop_code: "UN",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:09:51Z

    end
+
+    it "propagates its own Date to every stop, across every service and trip" do
+      date = Date.parse("2023-03-13")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:09:51Z

        to be_kind_of(GoTransit::Schedule::Journey::SchJourney)
    end
+
+    it "propagates its own Date to every stop, across every service and trip" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:09:51Z

+    it "raises MissingAnchorDateError when anchor_date was never assigned" do
+      stop = described_class.new(time: "07:00")
+
+      expect { stop.time_local }.to raise_error(GoTransit::MissingAnchorDateError)


Metrics/LineLength: Line is too long. [82/80]

hound · 2026-09-14T23:09:51Z

+      expect(stop.time_local.to_date).to eq(Date.new(2026, 1, 2))
+    end
+
+    it "raises MissingAnchorDateError when anchor_date was never assigned" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+    end
+
+    it "raises MissingAnchorDateError when anchor_date was never assigned" do
+      stop = GoTransit::Schedule::Journey::SchJourney::Service::Trip::Stop.new(time: "07:00")


Metrics/LineLength: Line is too long. [93/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+    end
+
+    it "rolls forward past the boundary hour, same rule as Schedule::Trip's stops" do
+      stop = GoTransit::Schedule::Journey::SchJourney::Service::Trip::Stop.new(time: "00:15")


Metrics/LineLength: Line is too long. [93/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+      expect(stop.time_utc).to eq(stop.time_local.utc)
+    end
+
+    it "rolls forward past the boundary hour, same rule as Schedule::Trip's stops" do


Metrics/LineLength: Line is too long. [85/80]

hound · 2026-09-14T23:13:18Z

+
+  describe "#time_local and #time_utc" do
+    it "resolve using the assigned anchor_date" do
+      stop = GoTransit::Schedule::Journey::SchJourney::Service::Trip::Stop.new(time: "07:00")


Metrics/LineLength: Line is too long. [93/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

  end
+
+  describe "#time_local and #time_utc" do
+    it "resolve using the assigned anchor_date" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+
+  describe "#scheduled_utc" do
+    it "converts the resolved local time to UTC" do
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "14:54")


Metrics/LineLength: Line is too long. [89/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+  end
+
+  describe "#scheduled_utc" do
+    it "converts the resolved local time to UTC" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+    end
+  end
+
+  describe "#scheduled_utc" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:13:18Z

+    it "raises MissingAnchorDateError when anchor_date was never assigned" do
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "14:54")
+
+      expect { arrival_time.scheduled_local }.


Layout/DotPosition: Place the . on the next line, together with the method name.

hound · 2026-09-14T23:13:18Z

+    end
+
+    it "raises MissingAnchorDateError when anchor_date was never assigned" do
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "14:54")


Metrics/LineLength: Line is too long. [89/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

The previous change added _utc/_local to every date and time field across the gem except two families that are returned as a bare "HH:MM", no date at all. Converting one of these to a real Time requires knowing which calendar date it belongs to, and GO Transit's own service date doesn't line up with calendar midnight: a service date starting at 6am can run past 2am the next calendar day, and every stop in that overnight tail still belongs to the original service date, not the next one. This change addresses the need by: * Adding a configurable service_day_boundary_hour (default 4) marking where one service date ends and the next begins * Resolving _utc/_local for these fields by anchoring to a known date rather than assuming "today", correctly handling a trip whose very first stop is already past midnight with no other stop to compare it against * Threading the anchor date through Schedule.trip and Schedule.journey automatically, so no caller has to supply one themselves

hound · 2026-09-14T23:20:46Z

+      expect(arrival_time.scheduled_local).to be_nil
+    end
+
+    it "raises MissingAnchorDateError when anchor_date was never assigned" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:46Z

+    end
+
+    it "returns nil when the underlying field is blank" do
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "")


Metrics/LineLength: Line is too long. [84/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:46Z

+      GoTransit.service_day_boundary_hour = original_boundary_hour
+    end
+
+    it "returns nil when the underlying field is blank" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:46Z

+    it "honors a custom service_day_boundary_hour" do
+      original_boundary_hour = GoTransit.service_day_boundary_hour
+      GoTransit.service_day_boundary_hour = 3
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "03:30")


Metrics/LineLength: Line is too long. [89/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:46Z

+      expect(result.to_date).to eq(Date.new(2026, 1, 2))
+    end
+
+    it "honors a custom service_day_boundary_hour" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:47Z

+RSpec.describe GoTransit::Schedule::Trip::Stop::ArrivalTime do
+  describe "#scheduled_local" do
+    it "stays on the anchor date when the hour is at or after the boundary" do
+      arrival_time = GoTransit::Schedule::Trip::Stop::ArrivalTime.new(scheduled: "23:58")


Metrics/LineLength: Line is too long. [89/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:47Z

@@ -0,0 +1,82 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop::ArrivalTime do
+  describe "#scheduled_local" do
+    it "stays on the anchor date when the hour is at or after the boundary" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:47Z

@@ -0,0 +1,82 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop::ArrivalTime do
+  describe "#scheduled_local" do


Metrics/BlockLength: Block has too many lines. [38/25]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2026-09-14T23:20:47Z

@@ -0,0 +1,82 @@
+RSpec.describe GoTransit::Schedule::Trip::Stop::ArrivalTime do


Metrics/BlockLength: Block has too many lines. [56/25]
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

hound · 2026-09-14T23:20:47Z

+    it "raises MissingAnchorDateError" do
+      departure_time = GoTransit::Schedule::Trip::Stop::DepartureTime.new(scheduled: "14:54")
+
+      expect { departure_time.scheduled_local }.


Layout/DotPosition: Place the . on the next line, together with the method name.

jmazur self-assigned this Sep 14, 2026

hound Bot reviewed Sep 14, 2026

View reviewed changes

jmazur force-pushed the jm-service-day-time-fields branch from b94ac48 to 06781d0 Compare September 14, 2026 23:20

hound Bot reviewed Sep 14, 2026

View reviewed changes

jmazur merged commit ed7f11a into main Sep 14, 2026
11 checks passed

jmazur deleted the jm-service-day-time-fields branch September 14, 2026 23:23

		@@ -0,0 +1,15 @@
		RSpec.describe GoTransit do
		describe ".service_day_boundary_hour" do

		@@ -0,0 +1,15 @@
		RSpec.describe GoTransit::Schedule::Trip::Stop do
		describe "#anchor_date=" do

		@@ -0,0 +1,82 @@
		RSpec.describe GoTransit::Schedule::Trip::Stop::ArrivalTime do
		describe "#scheduled_local" do

Conversation

jmazur commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

hound Bot Sep 14, 2026

jmazur commented Sep 14, 2026 •

edited

Loading