Repository navigation
fix(mcp): mark which flight and session tools are destructive - #123
Merged
Merged
Conversation
flight_create, flight_edit, flight_delete and session_refresh set no destructiveHint, so MCP clients read all four as destructive. Mark flight_edit and flight_delete destructive, and flight_create and session_refresh not, so a client that approves non-destructive writes on its own runs creating a flight or refreshing the session without asking, and still asks before overwriting or deleting one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flight_create,flight_edit,flight_deleteandsession_refreshsetreadOnlyHint: falsebut nodestructiveHint, so under MCP's default every client reads all four as destructive.This sets the hint explicitly:
flight_createfalsesession_refreshfalseflight_edittrueflight_deletetrueA client that approves non-destructive writes on its own (Hub chat's "Approve for me" with a tool on Auto) now runs
flight_createandsession_refreshwithout asking, and still asks beforeflight_editandflight_delete.Tests
TestMCP_ToolAnnotations_AllPresentnow covers the four tools.go test ./pkg/mcp/passes.