Repository navigation
fix(auth): validate device-login verification URLs - #118
Merged
Merged
Conversation
The device flow opened whatever verification URL the hub returned. A hostile or spoofed hub could hand back a file:, javascript:, or cross-origin address, and on Windows the URL went through cmd.exe. The verification URLs must now be HTTP(S) on the configured hub's origin, and Windows prints the URL for manual opening instead of shelling out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The device flow opened whatever verification URL the hub returned. A hostile or spoofed hub could return a
file:,javascript:, or cross-origin address, and on Windows the URL went throughcmd.exe, where shell metacharacters are interpreted.ValidateBrowserURLaccepts only HTTP(S) URLs with no embedded credentials or control characters.verification_uriandverification_uri_completeto match the configured hub's origin (scheme, host, effective port).cmd /c start.Testing
pkg/tapper/browser_security_test.gogo build,go vet,go test ./...,-racefor keg/tapper/paritytask lint:docs,task lint:fs