Repository navigation
Conversation
Local tap mcp accepted any absolute source_path, file: URI, or dest_path, so a prompt-injected agent could upload ~/.ssh keys to a keg or overwrite shell rc files. Sources must now resolve to regular files inside the server's working directory, with symlink and parent escapes refused. Downloads must name a new file there and are created exclusively with owner-only permissions. image_download is no longer marked read-only.
jlrickert
marked this pull request as draft
September 28, 2026 04:43
Owner
Author
|
Converting to draft: the working-directory confinement breaks existing local attachment transfers (uploads/downloads outside the MCP server's cwd, re-downloads to existing paths). Needs another pass before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local
tap mcpaccepted any absolutesource_path,file:URI, ordest_path. A prompt-injected agent could upload~/.sshkeys to a keg or overwrite a shell rc file.O_EXCLand0600, so an existing file or a final symlink is never overwritten.image_downloadtool is no longer annotated read-only.Testing
pkg/mcp/transfer_security_test.gocovers traversal, symlink escape, overwrite refusal, and the happy pathsgo build,go vet,go test ./...,-racefor keg/tapper/paritytask lint:docs,task lint:fs