Repository navigation
fix(config): strip logFile and logLevel from project config - #115
Merged
Merged
Conversation
A repository's .tapper/config.yaml could set logFile, which tap opens for append on every command, including the auto-started tap mcp. A cloned repo could therefore target a shell rc file. Logging is now user-config only, like hubs and relay, and a stripped value produces a load warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A repository's
.tapper/config.yamlcould setlogFile, whichtapopens for append on every command, including the auto-startedtap mcp. Cloning a hostile repo could therefore point Tapper at a shell rc file. Logging is now user-config only, likehubsandrelay, and a stripped value produces a load warning.Changes
pkg/tapper/config.go: project config dropslogFile/logLevelwith a warningschemas/tap-config.jsonanddocs/configuration/resolution-order.mdupdatedTesting
go build,go vet,go test ./...,-racefor keg/tapper/paritytask lint:docs,task lint:fs