Repository navigation
fix(codex): keep provider models out of cold ChatGPT routes - #2902
Open
jamie950315 wants to merge 1 commit into
Open
jamie950315 wants to merge 1 commit into
jamie950315 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The experimental client model catalog can aggregate native Codex and third-party provider models. Native routing currently treats that shared catalog as evidence that a ChatGPT account with no account-specific catalog can serve every listed model.
In a mixed-account installation this allowed
gemini-4-argonto select a ChatGPT credential instead of its API provider. The upstream rejected it withmodel_not_found. A subsequent continuation could then fail locally withcontinuation_history_incomplete/cipher_incompatiblewhen the gateway tried to rebuild the provider history for the wrong route. Background GPT requests sharing the same logical thread made this observable during continuation.Changes
History, opaque reasoning carriers, and encrypted-history safety checks are unchanged. This is independent of the tool-name restoration fix in #2901.
Validation
The same Rust source changes were validated on the local v1.3.73 repair installation. Current
maindiffers from that base only in documentation/Homebrew files, with no interveningsrc-taurichanges.native_provider_routes_tests: 8 passed.native_chatgpt_plan_tests: 13 passed.tauri/custom-protocol: passed.git diff --checkpasses.cargo fmt --manifest-path src-tauri/Cargo.toml --package cockpit-tools -- --checkreports existing repository-wide formatting differences, including untouchedsrc/commands/announcement.rsandsrc/commands/codex.rs; unrelated formatting is excluded from this PR.