feat(pairable_host): ready callback for alternate mdns implementation - #133
Open
meponderR wants to merge 2 commits into
Open
feat(pairable_host): ready callback for alternate mdns implementation#133meponderR wants to merge 2 commits into
meponderR wants to merge 2 commits into
Conversation
jkcoxson
reviewed
Sep 8, 2026
| name: *const c_char, | ||
| model: *const c_char, | ||
| port: u16, | ||
| ready_callback: Option< |
Owner
There was a problem hiding this comment.
https://users.rust-lang.org/t/option-is-ffi-safe-or-not/29820
Option isn't an FFI type
Owner
|
I have that one concern, it should be a pointer that should be checked for null instead of an |
Author
|
I just changed it to a checked pointer in 9be30c5. |
jkcoxson
reviewed
Sep 9, 2026
| name: *const c_char, | ||
| model: *const c_char, | ||
| port: u16, | ||
| ready_callback: *const c_void, |
Owner
There was a problem hiding this comment.
This should be a function pointer so the header is generated correctly. There are a few examples in this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for using a ready callback similar to StikPair. Primarily useful for skipping the multicast entitlement on iOS.
pairable_host_acceptworks as previously ifready_callbackis null, but is used if not. Should allow apps like StikPair that implement pairable host to be able to skip a multicast entitlement without having to make a rust ffi crate. I personally used it in my implementation for Auto Capture's pairing.AI Disclosure: Copilot was used to some extent. Code has been fully reviewed by myself and changed to ensure minimal changes to overall codebase. I apologize for having used it at all, I just kept having issues.