Keeper: Logging Improvements for Loki - #65
Open
aoikurokawa wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes and restructures logging across the keeper/writer services to be more Loki-friendly (key=value style) and to improve error formatting consistency.
Changes:
- Replaces verbose/pretty debug logs with structured key=value messages (e.g.,
epoch=...,count=...). - Standardizes error logging to prefer
{e:#}formatting for more informative error output. - Adjusts log levels/messages in a few flows (e.g., retry warnings, clearer service-specific wording).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| writer-service/src/stake_pool_manager.rs | Tweaks stake pool stats log output to be less verbose/structured. |
| writer-service/src/main.rs | Standardizes live/backfill error logging formatting. |
| writer-service/src/lib.rs | Standardizes error logs around DB write operations for multiple writers. |
| writer-service/src/bam_boost_manager.rs | Adds structured context (url/epoch) to BAM boost merkle tree fetch/parse logs. |
| steward-writer-service/src/main.rs | Converts multiple logs to structured fields; improves retry/error severity and messages. |
| cranker/src/utils.rs | Refactors transaction/update logging strings toward structured output. |
| cranker/src/main.rs | Standardizes error/warn formatting for update + Slack + polling retries. |
| bam-writer-service/src/main.rs | Makes epoch-threshold progress logs structured and more service-specific. |
| bam-writer-service/src/lib.rs | Makes override/skip logs more structured and consistent with key=value style. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.