Repository navigation
fix(core): improve extension-bundle discovery, error messages, and docs (#530, #534, #531) - #538
Merged
Conversation
- Unknown --with / extension-bundles install name now lists the valid bundle names from the signed catalog for that release, instead of a bare "not in the signed catalog" refusal (#530). - Add `urlcode extension-bundles list`: a static, network-free listing of the first-party bundle names this core release builds, for discovery before running `init --with` (#530). - A failed extension-bundle release fetch (init --with's auto-resolved extension-bundles@v<core>, or an explicit --bundle-release/install) now names --bundle-release <tag> as the pin-an-older-release escape hatch and notes the release publishes on a separate, slightly delayed workflow (#534). - Rewrite docs/EXTENSIONS.md's "Scaffolding with init --with" section to describe the current bundle-only resolution as the only behavior (retired npm-resolution text removed), correct the documented ScaffoldRequest/ScaffoldResult snippets against packages/core/src/extensions.ts, and document the new discovery command and error wording (#531). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related fixes to the
init --with/ extension-bundle seam, sharing the same code paths inpackages/core/src/extension-bundles.ts,init-with.tsanddocs/EXTENSIONS.md.#530 — no discovery path, unknown-name error didn't list valid options
installBundleinpackages/core/src/extension-bundles.tsnow includes the valid catalog names (sorted) when a requested bundle isn't in the signed catalog:(
catalog.bundles, already in scope there, is the source.)Added
urlcode extension-bundles list [--json]: prints the first-party bundle names this core release builds, with a one-line description each. This is a static, baked-in list (BUNDLE_CATALOG_NAMESinextension-bundles.ts, sourced from the same setscripts/prepare-extension-bundles.tsbuilds and the README workspace table), not a live network catalog fetch — a deliberate tradeoff to avoid a network dependency for a simple listing command, at the cost of it possibly being slightly stale relative to a specific--bundle-release's live catalog (documented indocs/EXTENSIONS.md).install/init --withstill verify against the live signed catalog, which remains authoritative.#534 — release-fetch failure gave a generic, unexplained error
installBundle's failedtransport.release(release)call (used by bothextension-bundles installandinit --with's auto-resolvedextension-bundles@v<core>) is now caught and enriched:The workflow-automation question (wiring
extension-bundles.ymlinto the core release pipeline) is a separate maintainer decision and was intentionally left untouched.#531 — docs described the retired npm-resolution path as current
Rewrote the "Scaffolding with
init --with" section ofdocs/EXTENSIONS.md:@jimhoyd/urlcode-<name>via Node package resolution / installing a compatible package set first —--withhas been bundle-only since fix: make urlcode init --with bundle-only, auto-resolving extension-bundles@v<core> #526.ScaffoldRequestinterface to match the authoritative type inpackages/core/src/extensions.ts(added the missingdistributionandacknowledgementsfields), and rounded out theScaffoldResultsnippet (provides/requires/after/conflicts,acknowledged,routeNotes,hostBundleExports) which the surrounding prose already described but the code sample omitted.npm installcommand" with the actual current refusal (not-in-catalog, listing valid names).urlcode extension-bundles listand its network-free/possibly-stale tradeoff.docs/), so no changelog entry was added; noting that here per the issue's ask.Test plan
npm run typechecknpm run check:code/npm run check:docs(regeneratedllms-full.txtvianpm run docs:llms, which was stale after the docs edit; no schema changed sodocs:referencewas a no-op check)npm test(777 tests, 776 pass / 1 pre-existing skip)npm run verify:workspaces(all six workspace packages, package audit, andtest/workspace-scaffold.integration.ts, which exercisesinit --withend-to-end)test/extension-bundles.test.ts(unknown-name catalog listing, enriched release-fetch-failure message including a check that an unrelated transport error is not rewritten,BUNDLE_CATALOG_NAMEScoverage),test/cli.test.ts(extension-bundles listtext/--jsonoutput and--helplisting)Closes #530
Closes #534
Closes #531
🤖 Generated with Claude Code