Constructs together: the nine design questions from the combinations check

[jimhoyd]

What this changes

Before: the combinations check in #66 left nine places where constructs disagreed when used together. A purchase counted twice in the ledger. Things in sub-folders dropped out of views. A sidecar's expires: never reached the calendar. @name worked only on its own in find. A resolved issue's to-dos kept coming due. Edits reformatted lists. Write results carried ciphertext. Organization membership and links disagreed. There were also a few display nits.

After:

1. Ledger: a thing's price is left out when its purchase event, the one with an amount that links to it, is logged. The purchase is the linking event dated on the thing's purchaseDate, or, when there's no purchaseDate, the one whose amount equals the price in the same currency. A service event that links with its own amount leaves the price counted.
2. Sub-folders: a collection includes the folders under it in every view, in the CLI and the browser.
3. Sidecars: a file's sidecar feeds upcoming, reminders, the calendar and .ics. Its links count in related and places.
4. Saved searches: @name expands anywhere a query is accepted (CLI, MCP, every browser search box) and combines with other terms. An unknown name is a NOT_FOUND error.
5. Resolved issues: their open to-dos, reminders and repeats leave todos, upcoming, reminders, the calendar and .ics (todos --all still lists them). The browser shows an Open or Resolved issue badge instead of the raw field.
6. Flow lists: edits keep each file's own style, so [bike] stays [bike] and [ bike ] stays padded.
7. Write results: they mask sealed values the way reads do (CLI --json and MCP).
8. Organizations:
   • org: "[Acme](…);Unit" counts as a link everywhere.
   • Membership by name fills orgPath when exactly one organization has that name.
   • Organizations list the things they supplied (things whose vendor: links to them).
9. Smaller ones:
   • CSV export says when it writes sealed fields. It keeps the ciphertext, so a re-import still works.
   • Links in fields and to-dos display as their text, and the browser links them.
   • An event logged today without a time no longer shows as upcoming.
   • The vCard export opens sealed properties with a key and lists them when there is none.
   • edit --text keeps the # Title unless the new text brings its own.

Why

Jimmy asked to fix the design questions raised by the combinations check (#66).

How it was tested

• make check passes (typecheck, tests, build, @gitroll/core build, audit): 414 pass, 0 fail, 1 skipped (the CI-only browser presence check), 0 vulnerabilities.
• Tests added or updated for every behavior change:
  • There are regression tests in test/ledger.test.ts, fields.test.ts, issues.test.ts and entities.test.ts.
  • test/combinations.test.ts is extended. It now moves the e-bike into inventory/bikes/ and the garage into places/home/, then checks every view.
  • Its browser checks cover issue badges, saved searches in a filter box, and links shown as text.

Anything a reviewer should look at closely

• Format of files in a Roll: SPEC.md now has rules for sub-folder collections, the purchase rule, sidecars on the calendar, and resolved issues on the calendar. No file format changes, and template_version is unchanged.
• Agent guide: it is now version 10.
• Mixed list styles: a file that mixes [a] and [ b ] takes the style of its first flow list.
• orgPath by name only looks in notes/organizations/.
• A resolved issue's due, warranty or expires fields stay on the calendar. Only to-dos, reminders and repeats are dropped.
• App.tsx: the diff is mostly re-indentation from a new saved-searches provider. git diff -w shows the real change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XCVQuXXVJBEB4WExAcfQfD

---

Generated by Claude Code