Skip to content

XRAY-160044 - Skip for local Go 'replace' modules - #885

Merged
gauriy-tech merged 4 commits into
jfrog:devfrom
Phavya-jfrog:feature/XRAY-160044-go-replace
Sep 17, 2026
Merged

gauriy-tech merged 4 commits into
jfrog:devfrom
Phavya-jfrog:feature/XRAY-160044-go-replace

Conversation

@Phavya-jfrog

@Phavya-jfrog Phavya-jfrog commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

jf curation-audit HEAD-probes every Go module in the dependency tree against Artifactory. When a module is satisfied by a local replace directive, Go reports it under its original name/placeholder version with no "local" signal - so it still gets probed, 404s, and flags the whole report as "may be incomplete."

Now parses go.mod's replace table directly to detect local-directory replaces and skips probing them.

Before
Screenshot 2026-09-16 at 12 58 38 PM

After
Screenshot 2026-09-16 at 12 58 55 PM

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: d202ae87-3e2d-4907-bc8f-6595be51e749

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@Phavya-jfrog Phavya-jfrog added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 16, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2026
@Phavya-jfrog
Phavya-jfrog force-pushed the feature/XRAY-160044-go-replace branch from 7f53f05 to 77ceac9 Compare September 16, 2026 08:46
@Phavya-jfrog Phavya-jfrog added bug Something isn't working safe to test Approve running integration tests on a pull request and removed improvement Automatically generated release notes labels Sep 16, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2026
Comment thread sca/bom/buildinfo/technologies/go/golang.go
Comment thread commands/curation/curationaudit_test.go
@gauriy-tech

Copy link
Copy Markdown
Collaborator

[Re: go.mod:150] golang.org/x/mod/modfile is now imported directly in sca/bom/buildinfo/technologies/go/golang.go, but go.mod still marks golang.org/x/mod as // indirect. Running go mod tidy would promote it to a direct dependency. Cosmetic only — doesn't affect build or CI (no go mod tidy --check gate in this repo's workflows).


Review generated by xray-pr-review

@Phavya-jfrog
Phavya-jfrog force-pushed the feature/XRAY-160044-go-replace branch from 74db1b6 to 3e7756a Compare September 17, 2026 03:51
@Phavya-jfrog Phavya-jfrog added the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@Phavya-jfrog Phavya-jfrog added the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@Phavya-jfrog Phavya-jfrog added the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@Phavya-jfrog Phavya-jfrog added the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@gauriy-tech
gauriy-tech merged commit 4799d2f into jfrog:dev Sep 17, 2026
104 of 122 checks passed
@Phavya-jfrog
Phavya-jfrog deleted the feature/XRAY-160044-go-replace branch September 17, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants