Feature/v2.2.8 - #307
Merged
Merged
Conversation
#305) …(#304) ## Summary - ## Type of Change - [x] Bug fix - [x] Feature - [ ] Documentation - [x] Refactor - [ ] Build, CI, or release - [ ] Other ## Related Issues Closes #302 #301 #298 #300 #299 ## Changes - ## Testing - [ ] `npm run build:main` - [ ] `npm run build:preload` - [ ] `npm run typecheck` - [ ] `npm run lint` - [ ] `npm run test:unit` - [ ] `Not run` ## Checklist - [ ] I kept this pull request focused and avoided unrelated refactors. - [ ] I followed the Electron layer boundary: Renderer → Preload/Bridge → Main. - [ ] I validated IPC input at the boundary when applicable. - [ ] I avoided `any`, `@ts-ignore`, and unnecessary `@ts-expect-error`. - [ ] I updated Simplified Chinese locale files for new or changed user-visible UI text. - [ ] I updated documentation when behavior, setup, or user-facing functionality changed. - [ ] I considered privacy, security, and user-data impact. --------- ## Summary - ## Type of Change - [ ] Bug fix - [ ] Feature - [ ] Documentation - [ ] Refactor - [ ] Build, CI, or release - [ ] Other ## Related Issues Closes # ## Changes - ## Testing - [ ] `npm run build:main` - [ ] `npm run build:preload` - [ ] `npm run typecheck` - [ ] `npm run lint` - [ ] `npm run test:unit` - [ ] `Not run` ## Checklist - [ ] I kept this pull request focused and avoided unrelated refactors. - [ ] I followed the Electron layer boundary: Renderer → Preload/Bridge → Main. - [ ] I validated IPC input at the boundary when applicable. - [ ] I avoided `any`, `@ts-ignore`, and unnecessary `@ts-expect-error`. - [ ] I updated Simplified Chinese locale files for new or changed user-visible UI text. - [ ] I updated documentation when behavior, setup, or user-facing functionality changed. - [ ] I considered privacy, security, and user-data impact. ## Summary - ## Type of Change - [ ] Bug fix - [ ] Feature - [ ] Documentation - [ ] Refactor - [ ] Build, CI, or release - [ ] Other ## Related Issues Closes # ## Changes - ## Testing - [ ] `npm run build:main` - [ ] `npm run build:preload` - [ ] `npm run typecheck` - [ ] `npm run lint` - [ ] `npm run test:unit` - [ ] `Not run` ## Checklist - [ ] I kept this pull request focused and avoided unrelated refactors. - [ ] I followed the Electron layer boundary: Renderer → Preload/Bridge → Main. - [ ] I validated IPC input at the boundary when applicable. - [ ] I avoided `any`, `@ts-ignore`, and unnecessary `@ts-expect-error`. - [ ] I updated Simplified Chinese locale files for new or changed user-visible UI text. - [ ] I updated documentation when behavior, setup, or user-facing functionality changed. - [ ] I considered privacy, security, and user-data impact. Co-authored-by: Jet <2314520+jetyu@users.noreply.github.com>
## Summary - ## Type of Change - [ ] Bug fix - [ ] Feature - [ ] Documentation - [ ] Refactor - [ ] Build, CI, or release - [ ] Other ## Related Issues Closes # ## Changes - ## Testing - [ ] `npm run build:main` - [ ] `npm run build:preload` - [ ] `npm run typecheck` - [ ] `npm run lint` - [ ] `npm run test:unit` - [ ] `Not run` ## Checklist - [ ] I kept this pull request focused and avoided unrelated refactors. - [ ] I followed the Electron layer boundary: Renderer → Preload/Bridge → Main. - [ ] I validated IPC input at the boundary when applicable. - [ ] I avoided `any`, `@ts-ignore`, and unnecessary `@ts-expect-error`. - [ ] I updated Simplified Chinese locale files for new or changed user-visible UI text. - [ ] I updated documentation when behavior, setup, or user-facing functionality changed. - [ ] I considered privacy, security, and user-data impact. --------- Co-authored-by: Jet <2314520+jetyu@users.noreply.github.com>
- Introduced a unified control for auto-continue functionality, ensuring it governs all input-triggered predictions. - Updated the settings page to clearly delineate functional areas: Basic Settings, Writing Preferences, Auto Continue, and Quick Actions. - Ensured that explicit AI operations remain independent of the auto-continue switch. - Enhanced global writing preferences to apply consistently across both automatic continuations and explicit editor operations. - Implemented regression tests to validate the new behavior and settings structure. - Refactored relevant components and services to accommodate the clarified functionality.
…n notes - Implement tests for AI completion editor controls, including suggestion acceptance and classification of editor changes. - Create tests for AI completion service, validating context building and suggestion sanitization. - Enhance AI writing prompts tests to include position-aware continuation and context serialization. - Introduce tests for knowledge copilot agent prompts and runtime, ensuring tool invocation and error handling. - Add tests for knowledge copilot image service, focusing on image understanding and error scenarios. - Implement markdown note image access tests, covering image discovery, availability checks, and reading images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Related Issues
Closes #
Changes
Testing
npm run build:mainnpm run build:preloadnpm run typechecknpm run lintnpm run test:unitNot runChecklist
any,@ts-ignore, and unnecessary@ts-expect-error.