Repository navigation
Stop the scout gate from discarding coupled-frame results; include unit clauses in the 2-SAT check - #34
Merged
Conversation
… never drops coupling wins Co-authored-by: jesusvilela <19171959+jesusvilela@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frame_solve_scoutedreturnedCDCL_NEEDEDon unit chains likex1, x1→…→xn, ¬xn, whichframe_solve_coupledrefutes. Separately,check_binary_clausesignored unit clauses, so it missed easy refutations.Scout gate (
_no_exploitable_structure)frame_solve_coupledwould also returnCDCL_NEEDED. The docstring's "never loses a frame win" claim is now true by construction, not just on the differential corpus.check_binary_clauses(a)is added as(a ∨ a), i.e. the single edge¬a → a. This is still sound, and it lets every router refute the chain above at the 2-SAT step.conflicting_variableisNonein that case.BinaryClauseCheckResult.num_unit_clauses(default0). Existing callers only read.consistent.Tests
test_binary_clause_check.py:TestScoutedGate:CDCL_NEEDED