Repository navigation
Polish bulk tag hover and session-row cursor - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two scoped CSS corrections, responsive regressions, and matching docs. Existing click/selection handlers, independent tag buttons, bounded scrolling, batch scope and save semantics are unchanged. This is a core presentation fix, not a setting or override.
Proof
Revision:
745c4f5ea20ab51549187e7c7e03b90d7f4989e5, targeting this fork’smain. Real isolated PocketApp routes/assets in Linux/Chromium, with synthetic sessions and a scripted model; no live data or mocked HTTP behavior.auto. After:pointer, followed by real opening of the correct conversation at all 3 widthstest/session-tags-polish-ui.test.tsValidation:
npm run format,npm run lint,npm run check,git diff --check, and the completenpm testrun pass: 440 tests, 440 passed, 0 failed/skipped, 651683ms. All 4 committed files match the SHA-256 manifest of that fully tested precommit candidate. The targeted 5-test UI run also passed. Both reported defects were reproduced by the same assertions before the CSS repair.The screenshots and 18-second native demo are attached below. The demo verifies a 0 CSS px right-edge gap, native opening, 2-session selection, right-edge removal and cancellation preserving both stored tag lists, with zero browser errors. It uses 90 real CDP screenshots sampled at approximately 5fps, duplicated to encode 10fps at 1280×800. No application behavior is simulated. A browser screenshot does not include the system cursor: the
pointervalue is machine-asserted, not claimed to be visible in the recording. Types, lint and all 5 targeted regressions also pass again on the exact commit.Limits: local Chromium integration and mobile emulation, not physical-device, other-engine, screen-reader or production acceptance. No new API or persistence behavior. This PR does not update upstream PR TannerMidd#118, change its restored description, merge anything, or update/restart the running installation.
native-demo.mp4