Fire a change event on ispin spinners and guard against double init - #3436
Open
Salvialf wants to merge 2 commits into
Open
Fire a change event on ispin spinners and guard against double init#3436Salvialf wants to merge 2 commits into
Salvialf wants to merge 2 commits into
Conversation
Mips2648
approved these changes
Jul 23, 2026
Salvialf
added
changelog-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spin()method (triggered by the +/- buttons, arrow keys, and mouse wheel) updates the input's value via JS without ever firing a nativechangeevent, so listeners relying onchange(e.g. an unsaved-parameter indicator) never fired for those interactions.onChangenow dispatches achangeevent to cover this gap.initSpinners()could be called multiple times on the same page (e.g. reopened modals), and the underlying ISpin library rewraps the input and rebinds its listeners unconditionally on every call, stacking duplicate wrappers/buttons and duplicate keydown/wheel listeners. Elements are now marked with anispinnedclass (same pattern astippiedfor tooltips) so they're skipped on subsequent calls.