Repository navigation
Fix _tp() to always return pandas Series - #202
Merged
Merged
Conversation
When amount column is present, _tp() was returning a numpy array instead of a pandas Series, causing inconsistent behavior in downstream indicators like MFI. Now both code paths consistently return a Series via to_series(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_tp()method to consistently return a pandas Series regardless of whetheramountcolumn is presentamountcolumn exists, the method was returning a numpy array instead of a Series, causing issues in downstream indicators like MFITest plan
test_mfi_with_amounttest to verify MFI works correctly with amount columnpytest --cov=stockstats test.py🤖 Generated with Claude Code