Repository navigation
Enforce strict compiler checks and declaration groups - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler previously checked nullable values but left other strict checks and JavaScript diagnostics off. Enable
strict,checkJs, and the additional indexed-access, optional-property, control-flow, unused-code, module, and declaration-file checks. Keep every owned JavaScript and TypeScript source in the program, and fix the exposed errors with checked values and schemas.Update
jdeurt/const-on-topto rejectconst–let–constandlet–const–letdeclaration sequences. Either kind can come first. Preserve declaration prefixes, ambient bindings, loop headers, and independent nested scopes. Order checks do not depend on whitespace, and the rule does not reorder code. The existing spacing rule remains separate.Disable only
unicorn/no-null. Compiler null safety remains enabled. Update the shared skill and maintenance documentation to match these policies.Validation:
bun run lint,bun run check-types,bun run format:check,bun run imports:check,bun run build,bun run check,bun test, and the publication dry run pass.