fix: pass system properties to native images - #2650
Open
jmini wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2649
A script run with --native never saw the -D properties given to JBang.
NativeCmdGenerator emitted only the image path and the user's arguments,
and NativeBuildStep does not hand them to native-image either, so nothing
was baked in at build time as a fallback. The properties were still applied
while building - for directive substitution and dependency resolution - so
jbang --native -Dfoo=barcould visibly change which dependencies wereresolved and then vanish before main() ran, without a warning.
A native image accepts -Dkey=value at run time just like a JVM does, so the
flags can simply be passed to the binary. Properties from -D and from a
//RUNTIME_OPTIONS directive are now forwarded.
Other runtime options are deliberately not forwarded, because a native image
treats them very differently: an unknown -XX: flag makes the binary exit with
"Could not find option", and options the image runtime does not recognise at
all (-agentlib:, -verbose:gc, ...) stay in the argument list and arrive as
program arguments. Since dropping them silently is what made this hard to
diagnose, JBang now warns instead.