Skip to content

Fix/slack alert quality#121

Merged
Alexanderamiri merged 3 commits intomainfrom
fix/slack-alert-quality
Apr 10, 2026
Merged

Fix/slack alert quality#121
Alexanderamiri merged 3 commits intomainfrom
fix/slack-alert-quality

Conversation

@Alexanderamiri
Copy link
Copy Markdown
Member

No description provided.

- Show GitHub actor name in "By:" line and source line instead of just
  the CI role name (e.g. "Alexanderamiri via javabin-ci-infra (CI/CD)")
- Pass tags to deletion and modification alerts (previously only on creation)
- Consolidate related deletion events on same resource (DeleteBucket,
  DeleteBucketWebsite, DeleteBucketPublicAccessBlock → single alert)
- Suppress SecurityHub/GuardDuty findings for resources recently managed
  by CI (10-minute window) to avoid noise from intentional changes
- Unify footer functions: replace context_footer with _build_footer
  so IAM changes and console logins also show actor info
Filters out noisy alerts for services under $10/day and spikes where
the absolute dollar difference is under $10. Matches ai-platform thresholds.
@Alexanderamiri Alexanderamiri requested a review from a team as a code owner April 10, 2026 12:51
@Alexanderamiri Alexanderamiri enabled auto-merge (squash) April 10, 2026 12:52
@github-actions
Copy link
Copy Markdown

Terraform Plan

🚧 Changes detected — Plan: 0 to add, 1 to change, 0 to destroy.

Plan output

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.lambdas.aws_lambda_function.daily_cost_check will be updated in-place
  ~ resource "aws_lambda_function" "daily_cost_check" {
        id                             = "javabin-daily-cost-check"
      ~ last_modified                  = "2026-03-26T21:51:39.000+0000" -> (known after apply)
      ~ source_code_hash               = "JJxy0PHHV4EJlt8QX2hACxRSBlHTNpMQJMTqeG/IvG4=" -> "VndMsCKmxhatnaL1WswTfMWyNKf3nfgGxJ+6E81YkrI="
        tags                           = {}
        # (21 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              + "MIN_SPIKE_AMOUNT"   = "10.00"
              + "MIN_SPIKE_DELTA"    = "10.00"
                # (4 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan"

LLM Review

Risk: 🟢 LOW

Routine Lambda function update for daily cost check with new environment variables and code changes.

  • [routine] Lambda function code update: source_code_hash changed, indicating function code has been modified
  • [routine] Environment variables added: MIN_SPIKE_AMOUNT and MIN_SPIKE_DELTA both set to 10.00, likely for cost anomaly detection thresholds
  • [routine] In-place update only - no resource destruction, no security group changes, no IAM modifications
  • 💰 [cost] No new billable resources being created; existing Lambda function is being updated with new configuration

@Alexanderamiri Alexanderamiri merged commit 4805917 into main Apr 10, 2026
3 checks passed
@Alexanderamiri Alexanderamiri deleted the fix/slack-alert-quality branch April 10, 2026 12:54
Alexanderamiri added a commit that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant