root - chore: pin memcached test-service image - #101
Merged
Conversation
Pin the floating memcached:latest tag to the concrete version it currently resolves to, for reproducible test runs. - memcached: latest -> 1.6.44 (docker-compose.yml x3, test/sasl/Dockerfile) Tag-only pin (no digest introduced). docker compose up -d --build rebuilds the SASL image on the pinned base; pnpm build and pnpm test:ci pass (612 tests, 100% statement/line coverage). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Memcached image version from 'latest' to a pinned version '1.6.44' in both the docker-compose.yml file and the test/sasl/Dockerfile to ensure environment predictability. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1399 1399
Branches 303 303
=========================================
Hits 1399 1399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the floating
memcached:latesttest-service image to the concrete version it currently resolves to, for reproducible test runs.Images
memcachedlatest→1.6.44Locations
docker-compose.yml:3— servicememcached1docker-compose.yml:11— servicememcached2docker-compose.yml:19— servicememcached3test/sasl/Dockerfile:1— SASL test image baseChecks
docker compose up -d --buildrebuilds the SASL image on the pinned base (apt packages resolve)pnpm build+pnpm test:cipass (612 tests, 100% statement/line coverage) against the pinned images🤖 Generated with Claude Code
https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
Generated by Claude Code