Fix startup failure: pass continue-on-error to the reusable workflow as an input - #209
Merged
Merged
Conversation
A job that calls a reusable workflow may not set 'continue-on-error';
GitHub rejects the whole file at startup ("Unexpected value
'continue-on-error'") before creating any jobs. The reusable-workflow
refactor in #199 moved the 'test' job to a reusable-workflow call while
keeping the job-level 'continue-on-error', taking CI dark on skeleton
and every downstream project that has since merged.
Move the setting into test-suite.yml as a boolean 'continue-on-error'
input and pass it through from the caller, preserving the
allow-3.15-to-fail behavior while keeping the version-specific logic in
main.yml.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jaraco
added a commit
that referenced
this pull request
Jul 14, 2026
A job that calls a reusable workflow may not set 'continue-on-error';
GitHub rejects the whole file at startup ("Unexpected value
'continue-on-error'") before creating any jobs. The reusable-workflow
refactor in #199 moved the 'test' job to a reusable-workflow
call while keeping the job-level 'continue-on-error', taking CI dark on
skeleton and every downstream project that has since merged.
Set continue-on-error on the reusable workflow's run job instead, keyed
on the pre-release Python version already special-cased there. This
preserves the allow-3.15-to-fail behavior in a single file, without
threading an extra input through the caller.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #199 refactored
main.ymlto call the reusabletest-suite.yml, thetestjob carries a job-levelcontinue-on-error:continue-on-erroris not a permitted key on a job that calls a reusable workflow. GitHub rejects the entire file at validation time:The run fails at startup (0s, no jobs, no checks) before anything executes. This has taken CI dark on skeleton itself (red on every commit since #199) and on every downstream project that has merged the skeleton since 2026-07-12 — the PR shows no checks running at all.
Fix
Move the setting into the reusable workflow as a boolean
continue-on-errorinput, applied to itsrunjob, and pass it through from the caller viawith:. This:3.15logic inmain.ymlwhere the matrix lives, sotest-suite.ymlstays version-agnostic.The
collateralcaller doesn't pass the input, so it defaults tofalse— no behavior change there.🤖 Generated with Claude Code